This is an archive of the discontinued LLVM Phabricator instance.

Explicitly add -target for Windows builds in file_test_windows.c
ClosedPublic

Authored by ayzhao on May 11 2022, 3:03 PM.

Details

Summary

It turns out that the llvm buildbots run the test with
-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4, which would cause this
test to fail as the test assumed that the default target is Windows. To
fix this, we explicitly set -target for the Windows testcases.

Diff Detail

Event Timeline

ayzhao created this revision.May 11 2022, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 3:03 PM
Herald added a subscriber: pengfei. · View Herald Transcript
ayzhao requested review of this revision.May 11 2022, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 3:03 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aeubanks accepted this revision.May 11 2022, 3:05 PM
This revision is now accepted and ready to land.May 11 2022, 3:05 PM
This revision was landed with ongoing or failed builds.May 11 2022, 3:09 PM
This revision was automatically updated to reflect the committed changes.