Rename and fix ValueMap::resize to reserve

[arkangath]

Summary

The underlying map type (DenseMap) has had its resize() function renamed to reserve() as part of c04fc7a60ff4ea4610ea157be006c9771224a7b6 (SVN 264026).

This is only visible when the member function is called, as it is template type name dependent.

[mehdi_amini]

Does it mean that there are no in-tree user for this API?
Are you gonna rename this to reserve as a follow-up patch? I'm not sure I got entirely why not rename it now (that is this API is broken anyway...)?

[arkangath]

In D125387#3507490, @mehdi_amini wrote:

Does it mean that there are no in-tree user for this API?

This would indicate yes.
I presume no one else (anywhere) uses it either otherwise we'd have been given a build failure bug report.

In D125387#3507490, @mehdi_amini wrote:

Are you gonna rename this to reserve as a follow-up patch? I'm not sure I got entirely why not rename it now (that is this API is broken anyway...)?

I intended to have the smallest impact on the patch, and commit as a build fix rather than an API change.
It can be renamed on this patch to reserve() on this patch if that's the preference.

[mehdi_amini]

Yeah probably best to rename it as the same time here. This won't break anyone considering the current state!
Thanks.

[mehdi_amini]

Thanks!

[arkangath]

Please note that I do not have commit rights.

[svenvh]

LGTM.

In D125387#3508744, @arkangath wrote:

Please note that I do not have commit rights.

I can take care of landing it.

llvm/include/llvm/IR/ValueMap.h

public:
   inline iterator end() { return iterator(Map.end()); }
   inline const_iterator begin() const { return const_iterator(Map.begin()); }
   inline const_iterator end() const { return const_iterator(Map.end()); }
 
   bool empty() const { return Map.empty(); }
   size_type size() const { return Map.size(); }
 
   /// Grow the map so that it has at least Size buckets. Does not shrink
-  void resize(size_t Size) { Map.resize(Size); }
+  void reserve(size_t Size) { Map.reserve(Size); }
 
   void clear() {
     Map.clear();
     MDMap.reset();
   }
 
   /// Return 1 if the specified key is in the map, 0 otherwise.
   size_type count(const KeyT &Val) const {