Page MenuHomePhabricator

PFerreira (Pedro Ferreira)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2016, 7:12 AM (161 w, 5 d)

Recent Activity

Dec 5 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

ping

Dec 5 2017, 2:18 AM

Nov 22 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Ping. Nearly there!

Nov 22 2017, 8:16 AM

Nov 7 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

I do not have commit access.

Nov 7 2017, 12:45 AM

Nov 2 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Ping.

Nov 2 2017, 4:12 AM

Oct 4 2017

PFerreira updated the diff for D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

I've added Eli's proof to it, not sure exactly how to present it.

Oct 4 2017, 3:45 AM

Oct 2 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

I have been fiddling with Alive, but it has been crashing on me (even on simple proofs). I guessed this was a temporary issue, but after 2 weeks it is still not working with "Oops, it seems that this tool encountered an issue."
The last version of the expression I got was

Oct 2 2017, 4:29 AM

Sep 1 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Ping. I understand people might be busy with 5.0

Sep 1 2017, 3:11 AM

Aug 14 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Just prodding for an update, in case the emails fell through.

Aug 14 2017, 2:24 AM

Jul 31 2017

PFerreira updated the diff for D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Added an explanation of what's being done.
Because I was the one writing it, it makes sense to me. Is it clear enough for others?

Jul 31 2017, 6:35 AM

Jul 25 2017

PFerreira updated the diff for D35475: [PATCH] [GVN] Ensure replacement instruction dominates its uses.

Keep track of BasicBlocks that have been processed and avoid doing PRE on blocks that haven't been operated on.

Jul 25 2017, 7:39 AM

Jul 19 2017

PFerreira updated the diff for D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Thanks for the suggestion. This was fun!

Jul 19 2017, 2:27 AM

Jul 18 2017

PFerreira added a comment to D35475: [PATCH] [GVN] Ensure replacement instruction dominates its uses.

A-ha, I see your point. Apologies for the confusion, but as I mentioned before, it was my hack on GVN.

Jul 18 2017, 1:06 AM
PFerreira updated the diff for D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Added the test you asked me about, slightly modified. I wanted to make sure that the ComputeKnownBits picked the correct bitwidth. The sample test you mentioned had the two inputs with the same bit width, so I just added two more. I can put it back to "3" if you prefer.

Jul 18 2017, 12:59 AM

Jul 17 2017

PFerreira added a comment to D35475: [PATCH] [GVN] Ensure replacement instruction dominates its uses.

I set a breakpoint in the R->moveBefore(I) which I added and this was the block in question:

Jul 17 2017, 8:35 AM
PFerreira created D35475: [PATCH] [GVN] Ensure replacement instruction dominates its uses.
Jul 17 2017, 2:04 AM
PFerreira updated the diff for D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Use TrailBitsKnown instead.

Jul 17 2017, 1:10 AM

Jul 14 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Hm, I'm not sure what I'm supposed to do next - do I wait for someone with commit rights to put this in?

Jul 14 2017, 2:19 AM

Jul 12 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Ping - maybe before the 5.0 branch?

Jul 12 2017, 12:16 AM

Jun 28 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Prodding the review, in case the emails regarding this slipped through.

Jun 28 2017, 6:31 AM

Jun 20 2017

PFerreira added inline comments to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.
Jun 20 2017, 2:08 AM
PFerreira updated the diff for D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Update diff following Craig's comment.

Jun 20 2017, 2:07 AM

Jun 12 2017

PFerreira added a comment to D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

New new patch addresses all of Craig's comments.

Jun 12 2017, 1:29 AM
PFerreira updated the diff for D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.

Updated the diff with the suggestions. I feel a bit silly for having made the first patch with that for-loop, when I used equivalent bit-ops further up the function.

Jun 12 2017, 1:28 AM

Jun 8 2017

PFerreira created D34029: Infer lowest bits of an integer Multiply when the low bits of the operands are known.
Jun 8 2017, 4:50 AM

Sep 8 2016

PFerreira added a comment to D21723: [RFC] Enhance synchscope representation.

I stumbled onto this as I was going through the mailing list.
We (Imagination) have a metadata solution in place and while we didn't have any problems describing the memory scopes all the way through to our codegen (the metadata didn't get lost as far as we can tell), the solution presented here does look more promising. We'd be interested in seeing this mainstreamed.

Sep 8 2016, 7:19 AM