Page MenuHomePhabricator
Differential D125251

[mlir] Fail early if AnalysisState::getBuffer() returns failure
ClosedPublic
Actions

Authored by ashay-github on May 9 2022, 11:27 AM.

Details

Reviewers
springerm
Commits
rG53ff0daa7e9d: [mlir] Fail early if AnalysisState::getBuffer() returns failure
Summary

This patch updates calls to AnalysisState::getBuffer() so that we return
early with a failure if the call does not succeed.

Diff Detail

Event Timeline

ashay-github created this revision.May 9 2022, 11:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2022, 11:27 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 19 others. · View Herald Transcript
ashay-github requested review of this revision.May 9 2022, 11:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2022, 11:27 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B163527: Diff 428140.May 9 2022, 1:23 PM
springerm accepted this revision.May 10 2022, 5:30 AM

nice cleanup thx!

This revision is now accepted and ready to land.May 10 2022, 5:30 AM
Closed by commit rG53ff0daa7e9d: [mlir] Fail early if AnalysisState::getBuffer() returns failure (authored by • ashay). · Explain WhyMay 10 2022, 8:08 AM
This revision was automatically updated to reflect the committed changes.
• ashay added a commit: rG53ff0daa7e9d: [mlir] Fail early if AnalysisState::getBuffer() returns failure.

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
Tensor/
Transforms/
63 lines

Diff 428384

View Options

mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp

Loading...