This is an archive of the discontinued LLVM Phabricator instance.

Differential D125153

[flang] Enforce limit on rank + corank
ClosedPublic

Authored by klausler on May 6 2022, 6:02 PM.

Details

Reviewers
vdonaldson
sscalpone
Commits
rG940871dd289c: [flang] Enforce limit on rank + corank
Summary

Fortran 2018 requires that a compiler allow objects whose rank + corank
is 15, and that's our maximum; detect and diagnose violations.

Diff Detail

Event Timeline

klausler created this revision.May 6 2022, 6:02 PM
Herald added a reviewer: sscalpone. · View Herald TranscriptMay 6 2022, 6:02 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.May 6 2022, 6:02 PM
vdonaldson accepted this revision.May 6 2022, 6:08 PM
This revision is now accepted and ready to land.May 6 2022, 6:08 PM
Harbormaster completed remote builds in B163274: Diff 427804.May 6 2022, 6:53 PM
Closed by commit rG940871dd289c: [flang] Enforce limit on rank + corank (authored by klausler). · Explain WhyMay 10 2022, 9:11 AM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG940871dd289c: [flang] Enforce limit on rank + corank.

Revision Contents

PathSize
flang/
lib/
Semantics/
11 lines
test/
Semantics/
31 lines

Diff 427804

flang/lib/Semantics/check-declarations.cpp

Context not available.
CheckArraySpec(symbol, details.shape()); CheckArraySpec(symbol, details.shape());
Check(details.shape()); Check(details.shape());
Check(details.coshape()); Check(details.coshape());
if (details.shape().Rank() > common::maxRank) {
messages_.Say(
"'%s' has rank %d, which is greater than the maximum supported rank %d"_err_en_US,
symbol.name(), details.shape().Rank(), common::maxRank);
} else if (details.shape().Rank() + details.coshape().Rank() >
common::maxRank) {
messages_.Say(
"'%s' has rank %d and corank %d, whose sum is greater than the maximum supported rank %d"_err_en_US,
symbol.name(), details.shape().Rank(), details.coshape().Rank(),
common::maxRank);
}
CheckAssumedTypeEntity(symbol, details); CheckAssumedTypeEntity(symbol, details);
WarnMissingFinal(symbol); WarnMissingFinal(symbol);
if (!details.coshape().empty()) { if (!details.coshape().empty()) {
Context not available.

flang/test/Semantics/maxrank.f90

  • This file was added.
! RUN: %python %S/test_errors.py %s %flang_fc1
! Enforce limits on rank + corank
module m
!ERROR: 'x' has rank 16, which is greater than the maximum supported rank 15
real :: x(1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1)
!ERROR: 'y' has rank 16, which is greater than the maximum supported rank 15
real, allocatable :: y(:,:,:,:,:,:,:,:,:,:,:,:,:,:,:,:)
!ERROR: 'z' has rank 16, which is greater than the maximum supported rank 15
real, pointer :: z(:,:,:,:,:,:,:,:,:,:,:,:,:,:,:,:)
!ERROR: 'w' has rank 16, which is greater than the maximum supported rank 15
real, dimension(1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1) :: w
!ERROR: 'a' has rank 15 and corank 1, whose sum is greater than the maximum supported rank 15
real :: a(1,1,1,1,1,1,1,1,1,1,1,1,1,1,1)[*]
!ERROR: 'b' has rank 14 and corank 2, whose sum is greater than the maximum supported rank 15
real :: b(1,1,1,1,1,1,1,1,1,1,1,1,1,1)[1,*]
!ERROR: 'c' has rank 14 and corank 2, whose sum is greater than the maximum supported rank 15
real :: c
dimension :: c(1,1,1,1,1,1,1,1,1,1,1,1,1,1)
codimension :: c[1,*]
interface
!ERROR: 'foo' has rank 16, which is greater than the maximum supported rank 15
real function foo()
dimension :: foo(1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1)
end function
end interface
contains
function bar() result(res)
!ERROR: 'res' has rank 16, which is greater than the maximum supported rank 15
real :: res(1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1)
end function
end module