This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Baseline tests for InstCombine optimization to merge GEP instructions with constant indices
AbandonedPublic

Authored by huangjd on May 5 2022, 8:20 PM.

Details

Summary

Baseline tests for InstCombine optimization to merge GEP instructions with constant indices

Diff Detail

Event Timeline

huangjd created this revision.May 5 2022, 8:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2022, 8:20 PM
huangjd requested review of this revision.May 5 2022, 8:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2022, 8:20 PM
nikic added inline comments.May 6 2022, 2:55 AM
llvm/test/Transforms/InstCombine/gep-merge-constant-indices.ll
2

If this is testing opaque pointers, it would be good if the input IR also used opaque pointers. Mixing both is a bit confusing.

davidxl accepted this revision.May 9 2022, 11:36 AM

lgtm with nikic's comment addressed.

This revision is now accepted and ready to land.May 9 2022, 11:36 AM

Should I use opaque ptr for the tests since it will be the default in LLVM in the future?

huangjd abandoned this revision.May 17 2022, 6:54 PM