This is an archive of the discontinued LLVM Phabricator instance.

[X86] Call initializeX86PreTileConfigPass from LLVMInitializeX86Target.
ClosedPublic

Authored by craig.topper on May 4 2022, 6:52 PM.

Details

Summary

Without this, the pass doesn't show up in print-before/after-all.

Diff Detail

Event Timeline

craig.topper created this revision.May 4 2022, 6:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 6:52 PM
craig.topper requested review of this revision.May 4 2022, 6:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 6:52 PM
LuoYuanke added inline comments.May 4 2022, 6:55 PM
llvm/lib/Target/X86/X86TargetMachine.cpp
70

Just be curious, why there is no error before without initialization?

craig.topper added inline comments.May 4 2022, 7:02 PM
llvm/lib/Target/X86/X86TargetMachine.cpp
70

I think all it really does is tell the pass registry about the pass. Somehow that's required for the printing code.

The analysis usage is put in the initialize function with INITIALIZE_PASS_DEPENDENCY which makes sure the initialize function for the dependency is called. The pass manager uses getAnalysis usage to determine what analysis passes need to run. That happens independent of the initialize function.

LuoYuanke accepted this revision.May 4 2022, 7:07 PM

LGTM, thanks!

This revision is now accepted and ready to land.May 4 2022, 7:07 PM
This revision was landed with ongoing or failed builds.May 4 2022, 7:11 PM
This revision was automatically updated to reflect the committed changes.