This is an archive of the discontinued LLVM Phabricator instance.

Differential D124968

[sanitizer] Use newfstatat for x32
ClosedPublic

Authored by hjl.tools on May 4 2022, 3:08 PM.

Details

Reviewers
dvyukov
eugenis
MaskRay
Commits
rGf52e365092aa: [sanitizer] Use newfstatat for x32
Summary

Since newfstatat is supported on x32, use it for x32.

Diff Detail

Event Timeline

hjl.tools created this revision.May 4 2022, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 3:08 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
hjl.tools requested review of this revision.May 4 2022, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 3:08 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B162804: Diff 427152.May 4 2022, 3:23 PM
eugenis accepted this revision.May 4 2022, 3:37 PM

LGTM

This revision is now accepted and ready to land.May 4 2022, 3:37 PM
MaskRay accepted this revision.May 4 2022, 3:38 PM
Closed by commit rGf52e365092aa: [sanitizer] Use newfstatat for x32 (authored by hjl.tools). · Explain WhyMay 4 2022, 3:56 PM
This revision was automatically updated to reflect the committed changes.
hjl.tools added a commit: rGf52e365092aa: [sanitizer] Use newfstatat for x32.
glaubitz added a subscriber: glaubitz.May 12 2022, 4:22 AM
This comment was removed by glaubitz.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
4 lines

Diff 427158

compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp

Show First 20 Lines • Show All 337 Lines • ▼ Show 20 Lines
#endif #endif
} }
#endif #endif
uptr internal_stat(const char *path, void *buf) { uptr internal_stat(const char *path, void *buf) {
#if SANITIZER_FREEBSD #if SANITIZER_FREEBSD
return internal_syscall(SYSCALL(fstatat), AT_FDCWD, (uptr)path, (uptr)buf, 0); return internal_syscall(SYSCALL(fstatat), AT_FDCWD, (uptr)path, (uptr)buf, 0);
# elif SANITIZER_LINUX # elif SANITIZER_LINUX
# if SANITIZER_WORDSIZE == 64 # if SANITIZER_WORDSIZE == 64 || SANITIZER_X32
return internal_syscall(SYSCALL(newfstatat), AT_FDCWD, (uptr)path, (uptr)buf, return internal_syscall(SYSCALL(newfstatat), AT_FDCWD, (uptr)path, (uptr)buf,
0); 0);
# else # else
struct stat64 buf64; struct stat64 buf64;
int res = internal_syscall(SYSCALL(fstatat64), AT_FDCWD, (uptr)path, int res = internal_syscall(SYSCALL(fstatat64), AT_FDCWD, (uptr)path,
(uptr)&buf64, 0); (uptr)&buf64, 0);
stat64_to_stat(&buf64, (struct stat *)buf); stat64_to_stat(&buf64, (struct stat *)buf);
return res; return res;
# endif # endif
# else # else
struct stat64 buf64; struct stat64 buf64;
int res = internal_syscall(SYSCALL(stat64), path, &buf64); int res = internal_syscall(SYSCALL(stat64), path, &buf64);
stat64_to_stat(&buf64, (struct stat *)buf); stat64_to_stat(&buf64, (struct stat *)buf);
return res; return res;
# endif # endif
} }
uptr internal_lstat(const char *path, void *buf) { uptr internal_lstat(const char *path, void *buf) {
#if SANITIZER_FREEBSD #if SANITIZER_FREEBSD
return internal_syscall(SYSCALL(fstatat), AT_FDCWD, (uptr)path, (uptr)buf, return internal_syscall(SYSCALL(fstatat), AT_FDCWD, (uptr)path, (uptr)buf,
AT_SYMLINK_NOFOLLOW); AT_SYMLINK_NOFOLLOW);
# elif SANITIZER_LINUX # elif SANITIZER_LINUX
# if defined(_LP64) # if defined(_LP64) || SANITIZER_X32
return internal_syscall(SYSCALL(newfstatat), AT_FDCWD, (uptr)path, (uptr)buf, return internal_syscall(SYSCALL(newfstatat), AT_FDCWD, (uptr)path, (uptr)buf,
AT_SYMLINK_NOFOLLOW); AT_SYMLINK_NOFOLLOW);
# else # else
struct stat64 buf64; struct stat64 buf64;
int res = internal_syscall(SYSCALL(fstatat64), AT_FDCWD, (uptr)path, int res = internal_syscall(SYSCALL(fstatat64), AT_FDCWD, (uptr)path,
(uptr)&buf64, AT_SYMLINK_NOFOLLOW); (uptr)&buf64, AT_SYMLINK_NOFOLLOW);
stat64_to_stat(&buf64, (struct stat *)buf); stat64_to_stat(&buf64, (struct stat *)buf);
return res; return res;
▲ Show 20 Lines • Show All 1,925 Lines • Show Last 20 Lines