More test coverage for the parts added by the One Ranges Proposal.
Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rGb06049bc3b79: [libc++][NFC] Add more tests to `move_{iterator,sentinel}`.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
LGTM with passing tests (the issue looks fairly benign) and after you've investigated whether we can test with more archetypes. Thanks for adding these tests!
libcxx/test/std/iterators/predef.iterators/move.iterators/move.iter.ops/move.iter.op.-/sentinel.pass.cpp | ||
---|---|---|
84–85 | What about cpp20_input_iterator? And output_iterator? I think it may be possible to improve test coverage here and elsewhere by adding tests with a couple more archetypes. |
What about cpp20_input_iterator? And output_iterator? I think it may be possible to improve test coverage here and elsewhere by adding tests with a couple more archetypes.