This is an archive of the discontinued LLVM Phabricator instance.

[libc++][NFC] Add more tests to `move_{iterator,sentinel}`.
ClosedPublic

Authored by var-const on May 4 2022, 12:59 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGb06049bc3b79: [libc++][NFC] Add more tests to `move_{iterator,sentinel}`.
Summary

More test coverage for the parts added by the One Ranges Proposal.

Diff Detail

Event Timeline

var-const created this revision.May 4 2022, 12:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 12:59 AM
Herald added a subscriber: arphaman. · View Herald Transcript
var-const requested review of this revision.May 4 2022, 12:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2022, 12:59 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 10 2022, 1:54 PM
ldionne added a subscriber: ldionne.

LGTM with passing tests (the issue looks fairly benign) and after you've investigated whether we can test with more archetypes. Thanks for adding these tests!

libcxx/test/std/iterators/predef.iterators/move.iterators/move.iter.ops/move.iter.op.-/sentinel.pass.cpp
83–84

What about cpp20_input_iterator? And output_iterator? I think it may be possible to improve test coverage here and elsewhere by adding tests with a couple more archetypes.

This revision is now accepted and ready to land.May 10 2022, 1:54 PM
var-const updated this revision to Diff 430867.May 19 2022, 7:06 PM

Fix bad merge, should fix the CI.

var-const updated this revision to Diff 430927.May 20 2022, 2:44 AM

Fix CI and rebase.

var-const updated this revision to Diff 431559.May 23 2022, 7:28 PM

Fix old language modes.

var-const updated this revision to Diff 431579.May 23 2022, 8:53 PM

Fix the CI.

var-const updated this revision to Diff 431841.May 24 2022, 4:53 PM

Fix the CI.

libcxx/test/std/iterators/predef.iterators/move.iterators/move.iter.ops/move.iter.op.conv/base.pass.cpp