This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Make GetSharedModuleWithLocalCache consider the device support directory
ClosedPublic

Authored by JDevlieghere on May 2 2022, 1:16 PM.

Details

Summary

Make GetSharedModuleWithLocalCache consider the device support directory. In the past we only needed the device support directory to debug remote processes. Since the introduction of Apple Silicon and Rosetta this stopped being true. When debugging a Rosetta process on macOS we need to consider the Rosetta expanded shared cache. This patch and it dependencies move that logic out of PlatfromRemoteDarwinDevice into a new abstract class called PlatfromDarwinDevice. The new platform sit in between PlatformDarwin and PlatformMacOSX and PlatformRemoteDarwinDevice and has all the necessary logic to deal with the device support directory.

Technically I could have moved everything in PlatfromDarwinDevice into PlatfromDarwin but decided that this logic is sufficiently self contained that it warrants its own abstraction.

rdar://91966349

Diff Detail

Event Timeline

JDevlieghere created this revision.May 2 2022, 1:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2022, 1:16 PM
mib accepted this revision.May 2 2022, 1:35 PM

LGTM!

This revision is now accepted and ready to land.May 2 2022, 1:35 PM
This revision was landed with ongoing or failed builds.May 2 2022, 9:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2022, 9:07 PM