This is an archive of the discontinued LLVM Phabricator instance.

[ADT][NFC] Add missing closing comment for `llvm` namespace
AbandonedPublic

Authored by ken-matsui on Apr 29 2022, 4:39 PM.

Details

Reviewers
None
Summary

As clang-tidy suggested adding a closing comment for the llvm namespace, I added it.

Diff Detail

Event Timeline

ken-matsui created this revision.Apr 29 2022, 4:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2022, 4:39 PM
ken-matsui requested review of this revision.Apr 29 2022, 4:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2022, 4:39 PM
whisperity retitled this revision from [clang-tidy] Add missing closing comment for `llvm` namespace to [ADT][NFC] Add missing closing comment for `llvm` namespace.Apr 30 2022, 5:10 AM
whisperity added a subscriber: whisperity.

This is unrelated to Clang-Tidy, the change affects the LLVM ADT library.

(Also, what is the policy for commits like these? This seems to be like borderline noise, a simple formatting commit, nothing else.)

It is not achieving anything, but also breaks the formatting rules that are found in other parts of the project. For example, APInt.h is terminated with } // namespace llvm and not } // end namespace llvm, see http://github.com/llvm/llvm-project/blob/40a2e35599b5e5fa0dd93ac4edf4bf02ee636f6e/llvm/include/llvm/ADT/APInt.h#L2301.

ken-matsui abandoned this revision.Apr 30 2022, 6:40 AM

Oh, I didn't know their policy aren't unified and thought this file just wasn't adapted because we have .clang-tidy. Closing.