As clang-tidy suggested adding a closing comment for the llvm namespace, I added it.
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
This is unrelated to Clang-Tidy, the change affects the LLVM ADT library.
(Also, what is the policy for commits like these? This seems to be like borderline noise, a simple formatting commit, nothing else.)
It is not achieving anything, but also breaks the formatting rules that are found in other parts of the project. For example, APInt.h is terminated with } // namespace llvm and not } // end namespace llvm, see http://github.com/llvm/llvm-project/blob/40a2e35599b5e5fa0dd93ac4edf4bf02ee636f6e/llvm/include/llvm/ADT/APInt.h#L2301.
Comment Actions
Oh, I didn't know their policy aren't unified and thought this file just wasn't adapted because we have .clang-tidy. Closing.