Page MenuHomePhabricator

ken-matsui (Ken Matsui)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 26 2022, 11:47 PM (8 w, 4 d)

Recent Activity

May 16 2022

ken-matsui added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

Thank you!

May 16 2022, 3:52 PM · Restricted Project, Restricted Project
ken-matsui added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

@nickdesaulniers
Thank you for your review!

May 16 2022, 3:32 PM · Restricted Project, Restricted Project
ken-matsui added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

Sorry for having missed it. Thank you!

May 16 2022, 3:24 PM · Restricted Project, Restricted Project
ken-matsui updated the diff for D125727: [clang] Avoid suggesting typoed directives in `.S` files.

Remove - < %s

May 16 2022, 3:23 PM · Restricted Project, Restricted Project
ken-matsui added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

Removed it 👍

May 16 2022, 3:07 PM · Restricted Project, Restricted Project
ken-matsui updated the diff for D125727: [clang] Avoid suggesting typoed directives in `.S` files.

Remove -x assembler-with-cpp

May 16 2022, 3:07 PM · Restricted Project, Restricted Project
ken-matsui added inline comments to D125727: [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 3:00 PM · Restricted Project, Restricted Project
ken-matsui added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

Thank you for your review! I've fixed it.

May 16 2022, 2:58 PM · Restricted Project, Restricted Project
ken-matsui updated the diff for D125727: [clang] Avoid suggesting typoed directives in `.S` files.

Update the code as reviewed

May 16 2022, 2:58 PM · Restricted Project, Restricted Project
ken-matsui added a comment to D124726: Suggest typoed directives in preprocessor conditionals.

I see. Thank you. I fixed the issue using its workaround.

May 16 2022, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui requested review of D125727: [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 2:26 PM · Restricted Project, Restricted Project
ken-matsui added a comment to D124726: Suggest typoed directives in preprocessor conditionals.

Oops, thank you for your comment!
I would like to work on a hotfix patch for this issue.

May 16 2022, 12:32 PM · Restricted Project, Restricted Project, Restricted Project

May 13 2022

ken-matsui added a comment to D124726: Suggest typoed directives in preprocessor conditionals.

Thank you for your support!

May 13 2022, 6:59 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124726: Suggest typoed directives in preprocessor conditionals.

I prepared a new public email address: vcs@kmatsui.me instead of the auto-generated one.
So, could you please use the new one for future commit?

May 13 2022, 1:33 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124726: Suggest typoed directives in preprocessor conditionals.
May 13 2022, 1:24 AM · Restricted Project, Restricted Project, Restricted Project

May 12 2022

ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Revert the changes for errored directives

May 12 2022, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added inline comments to D124726: Suggest typoed directives in preprocessor conditionals.
May 12 2022, 10:42 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Add test for errored directive but no suggestion

May 12 2022, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Update the code as reviewed and add a release note

May 12 2022, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124726: Suggest typoed directives in preprocessor conditionals.

Thank you for your review :)

May 12 2022, 9:58 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

I fixed it!

May 12 2022, 5:24 AM · Restricted Project, Restricted Project
ken-matsui updated the diff for D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

Fix the failed test

May 12 2022, 5:23 AM · Restricted Project, Restricted Project

May 11 2022

ken-matsui added a comment to D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

Thank you so much for your review!

May 11 2022, 7:35 PM · Restricted Project, Restricted Project
ken-matsui updated the diff for D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

Updated the code as reviewed, added a release note, and merged ext-cpp2b-pp-directive.cpp & ext-c2x-pp-directive.c into ext-pp-directive.c.

May 11 2022, 7:32 PM · Restricted Project, Restricted Project
ken-matsui added inline comments to D124726: Suggest typoed directives in preprocessor conditionals.
May 11 2022, 6:27 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Remove unused includes in StringRef.h

May 11 2022, 6:20 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124726: Suggest typoed directives in preprocessor conditionals.

Thank you for your support!

May 11 2022, 6:18 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Update the code as reviewed

May 11 2022, 6:18 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added inline comments to D124726: Suggest typoed directives in preprocessor conditionals.
May 11 2022, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

I believe the problem was already fixed by the @aaron.ballman's patch here.

May 11 2022, 6:19 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

Thank you for your review! I updated the code.

May 11 2022, 5:42 AM · Restricted Project, Restricted Project
ken-matsui updated the diff for D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

Update the code as reviewed

May 11 2022, 5:42 AM · Restricted Project, Restricted Project
ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

That looks to be exactly what I needed, but you can double-check that you were properly attributed here: https://github.com/llvm/llvm-project/commit/786c721c2bbd2e0646e314671e010859550423bf
I added one when I landed. I also adjusted the commit message slightly from what you have here in Phab for some added clarity.

May 11 2022, 4:16 AM · Restricted Project, Restricted Project, Restricted Project

May 10 2022

ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

LGTM, thank you for all the hard work on this! I assume you need me to land this on your behalf -- if so, can you let me know what name and email address you would like me to use for patch attribution?

May 10 2022, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added inline comments to D124726: Suggest typoed directives in preprocessor conditionals.
May 10 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Set AllowReplacements to true

May 10 2022, 12:53 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Fix the test as reviewed

May 10 2022, 11:44 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Thank you for your review! I'm going to fix them :)

May 10 2022, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D125078: Implement a feature to show line numbers in diagnostics.

Thank you all so much :)))

May 10 2022, 10:56 AM · Restricted Project, Restricted Project
ken-matsui updated the diff for D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

Fix failed tests

May 10 2022, 10:47 AM · Restricted Project, Restricted Project
ken-matsui added a comment to D125078: Implement a feature to show line numbers in diagnostics.

Thank you :)

May 10 2022, 9:55 AM · Restricted Project, Restricted Project
ken-matsui retitled D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode from Warn if using `elifdef` & `elifndef` in not C2x mode to Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.
May 10 2022, 8:46 AM · Restricted Project, Restricted Project
ken-matsui added inline comments to D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.
May 10 2022, 8:45 AM · Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Fix the test for FindSimilarStr

May 10 2022, 8:41 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

It looks like precommit CI caught some related failures:

Failed Tests (7):
  Clang :: Lexer/deprecate-macro.c
  Clang :: Lexer/unsafe-macro.c
  Clang :: Preprocessor/elifdef.c
  Clang :: Preprocessor/if_warning.c
  Clang :: Preprocessor/ifdef-recover.c
  Clang :: Preprocessor/macro_misc.c
  Clang :: Preprocessor/macro_vaopt_check.cpp
May 10 2022, 8:21 AM · Restricted Project, Restricted Project
ken-matsui updated the diff for D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Update test codes as reviewed

May 10 2022, 8:02 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

Thank you so much for your review!

May 10 2022, 6:52 AM · Restricted Project, Restricted Project
ken-matsui updated the diff for D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.

Update the code as reviewed

May 10 2022, 6:52 AM · Restricted Project, Restricted Project
ken-matsui added inline comments to D124534: [clang] Add a diagnostic for line directive of a gnu extension.
May 10 2022, 5:18 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Thank you for your review!

May 10 2022, 5:09 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added inline comments to D124726: Suggest typoed directives in preprocessor conditionals.
May 10 2022, 4:18 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Updated the code as reviewed

May 10 2022, 4:18 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D125078: Implement a feature to show line numbers in diagnostics.

This feature is already implemented in GCC, so in my opinion, it would be great if we could turn this on by default.

May 10 2022, 2:10 AM · Restricted Project, Restricted Project
ken-matsui added inline comments to D124534: [clang] Add a diagnostic for line directive of a gnu extension.
May 10 2022, 12:00 AM · Restricted Project, Restricted Project, Restricted Project

May 9 2022

ken-matsui updated the diff for D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Add a test file that uses the -Wsystem-headers option.

May 9 2022, 11:58 PM · Restricted Project, Restricted Project, Restricted Project

May 7 2022

ken-matsui requested review of D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode.
May 7 2022, 2:37 PM · Restricted Project, Restricted Project
ken-matsui updated the summary of D125175: Show location info with a new line in diagnostics.
May 7 2022, 12:11 PM · Restricted Project, Restricted Project
ken-matsui requested review of D125175: Show location info with a new line in diagnostics.
May 7 2022, 12:09 PM · Restricted Project, Restricted Project
ken-matsui added inline comments to D124726: Suggest typoed directives in preprocessor conditionals.
May 7 2022, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

After some investigations, some directives behave weirdly.
I will continue investigating, but do you have any suggestions here?

May 7 2022, 1:25 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Thank you for your review and sorry to have missed those directives!

May 7 2022, 1:04 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2022

ken-matsui updated the diff for D125078: Implement a feature to show line numbers in diagnostics.

Remove unnecessary includes

May 6 2022, 12:30 AM · Restricted Project, Restricted Project
ken-matsui requested review of D125078: Implement a feature to show line numbers in diagnostics.
May 6 2022, 12:28 AM · Restricted Project, Restricted Project

May 5 2022

ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

I could suppress the strange warnings by using isWrittenInBuiltinFile and isWrittenInCommandLineFile. Thank you!
Could you please review this patch?

May 5 2022, 3:59 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Update codes as reviewed

May 5 2022, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Remove unnecessary includes

May 5 2022, 3:55 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124726: Suggest typoed directives in preprocessor conditionals.

Update codes as reviewed

May 5 2022, 3:52 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added inline comments to D124726: Suggest typoed directives in preprocessor conditionals.
May 5 2022, 1:13 AM · Restricted Project, Restricted Project, Restricted Project

May 4 2022

ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

The tests run in -cc1 mode and don't #include anything, so I don't think the issue is an internally included SDK. I think the issue could be from this: https://github.com/llvm/llvm-project/blob/main/clang/lib/Frontend/InitPreprocessor.cpp#L1355 and https://github.com/llvm/llvm-project/blob/main/clang/lib/Frontend/InitPreprocessor.cpp#L1368. You may have to hook up to a debugger to see why we're issuing those surprising warnings. If it turns out that it's these inserted directives, you may have to look at the source location of the digit token to see if isWrittenInBuiltinFile() is true or not (and we may need to also check isWrittenInScratchSpace() as well, perhaps).

May 4 2022, 7:02 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124726: Suggest typoed directives in preprocessor conditionals.

Thank you so much for your clear review!

May 4 2022, 7:00 PM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

If so, I think putting Diag after the call of this function would be better.

May 3 2022, 7:09 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added inline comments to D124534: [clang] Add a diagnostic for line directive of a gnu extension.
May 3 2022, 10:31 AM · Restricted Project, Restricted Project, Restricted Project

Apr 30 2022

ken-matsui added inline comments to D124726: Suggest typoed directives in preprocessor conditionals.
Apr 30 2022, 8:50 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui requested review of D124726: Suggest typoed directives in preprocessor conditionals.
Apr 30 2022, 8:34 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui abandoned D124705: [ADT][NFC] Add missing closing comment for `llvm` namespace.

Oh, I didn't know their policy aren't unified and thought this file just wasn't adapted because we have .clang-tidy. Closing.

Apr 30 2022, 6:40 AM · Restricted Project, Restricted Project

Apr 29 2022

ken-matsui retitled D124534: [clang] Add a diagnostic for line directive of a gnu extension from Add a diagnostic for line directive of a gnu extension to [clang] Add a diagnostic for line directive of a gnu extension.
Apr 29 2022, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui requested review of D124705: [ADT][NFC] Add missing closing comment for `llvm` namespace.
Apr 29 2022, 4:39 PM · Restricted Project, Restricted Project
ken-matsui updated the diff for D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Add a diagnostic for line directive of a gnu extension

Apr 29 2022, 3:47 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added inline comments to D124534: [clang] Add a diagnostic for line directive of a gnu extension.
Apr 29 2022, 1:21 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added inline comments to D124534: [clang] Add a diagnostic for line directive of a gnu extension.
Apr 29 2022, 9:12 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

Thank you!

Apr 29 2022, 3:48 AM · Restricted Project, Restricted Project

Apr 28 2022

ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Thanks for your kind reviews!
I’ve updated the code, but is this what you’d expected?

Apr 28 2022, 3:29 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Add a diagnostic for line directive of a gnu extension

Apr 28 2022, 3:28 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

I see. Thank you for the detailed information!

Apr 28 2022, 9:41 AM · Restricted Project, Restricted Project
ken-matsui added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

Sorry, I'm a newbie here, but is there anything I should do after getting approved?

Apr 28 2022, 8:25 AM · Restricted Project, Restricted Project
ken-matsui added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

Thank you for your review!

Apr 28 2022, 8:20 AM · Restricted Project, Restricted Project
ken-matsui added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

Thank you for your suggestion! I’ve updated the summary.

Apr 28 2022, 8:11 AM · Restricted Project, Restricted Project
ken-matsui updated the summary of D124556: [NFC] Prevent shadowing a variable declared in `if`.
Apr 28 2022, 8:10 AM · Restricted Project, Restricted Project
ken-matsui added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

Sorry to have missed providing a summary.

Apr 28 2022, 5:46 AM · Restricted Project, Restricted Project

Apr 27 2022

ken-matsui requested review of D124556: [NFC] Prevent shadowing a variable declared in `if`.
Apr 27 2022, 2:08 PM · Restricted Project, Restricted Project
ken-matsui retitled D124534: [clang] Add a diagnostic for line directive of a gnu extension from Add a warning diagnostic for line directive of a gnu extension to Add a diagnostic for line directive of a gnu extension.
Apr 27 2022, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Thank you for your review! I updated the code.

Apr 27 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui updated the diff for D124534: [clang] Add a diagnostic for line directive of a gnu extension.

Add a diagnostic for line directive of a gnu extension

Apr 27 2022, 1:48 PM · Restricted Project, Restricted Project, Restricted Project
ken-matsui added a comment to D124534: [clang] Add a diagnostic for line directive of a gnu extension.
Apr 27 2022, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
ken-matsui requested review of D124534: [clang] Add a diagnostic for line directive of a gnu extension.
Apr 27 2022, 9:19 AM · Restricted Project, Restricted Project, Restricted Project