This is an archive of the discontinued LLVM Phabricator instance.

Differential D124619

[llvm] Ignore .rej files in .gitignore
ClosedPublic

Authored by JDevlieghere on Apr 28 2022, 8:21 AM.

Details

Reviewers
vsavchenko
sammccall
mehdi_amini
Commits
rG0fe9a5f71a64: [llvm] Ignore .rej files in .gitignore
Summary

Ignore reject files (.rej) files generated by patch. I can't imagine a reason they should ever be checked in. I'm wondering if we should ignore patch files as well but, though maybe we don't want them to be that easily deleted by something like git clean.

Diff Detail

Unit TestsFailed

TimeTest
60,030 msx64 debian > libFuzzer.libFuzzer::large.test

Event Timeline

JDevlieghere created this revision.Apr 28 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 8:21 AM
JDevlieghere requested review of this revision.Apr 28 2022, 8:21 AM
vsavchenko accepted this revision.Apr 28 2022, 8:24 AM

I guess the only possible scenario that I can imagine here for including these files is tests. Tests for some code tools dealing with patches.
Otherwise, 100% reasonable.

This revision is now accepted and ready to land.Apr 28 2022, 8:24 AM
mehdi_amini accepted this revision.Apr 28 2022, 8:26 AM
This revision was landed with ongoing or failed builds.Apr 28 2022, 8:45 AM
Closed by commit rG0fe9a5f71a64: [llvm] Ignore .rej files in .gitignore (authored by JDevlieghere). · Explain Why
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rG0fe9a5f71a64: [llvm] Ignore .rej files in .gitignore.
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 8:45 AM
Harbormaster completed remote builds in B161802: Diff 425789.Apr 28 2022, 9:11 AM

Revision Contents

PathSize
2 lines

Diff 425789

.gitignore

#==============================================================================# #==============================================================================#
# This file specifies intentionally untracked files that git should ignore. # This file specifies intentionally untracked files that git should ignore.
# See: http://www.kernel.org/pub/software/scm/git/docs/gitignore.html # See: http://www.kernel.org/pub/software/scm/git/docs/gitignore.html
# #
# This file is intentionally different from the output of `git svn show-ignore`, # This file is intentionally different from the output of `git svn show-ignore`,
# as most of those are useless. # as most of those are useless.
#==============================================================================# #==============================================================================#
#==============================================================================# #==============================================================================#
# File extensions to be ignored anywhere in the tree. # File extensions to be ignored anywhere in the tree.
#==============================================================================# #==============================================================================#
# Temp files created by most text editors. # Temp files created by most text editors.
*~ *~
# Merge files created by git. # Merge files created by git.
*.orig *.orig
# Reject files created by patch.
*.rej
# Byte compiled python modules. # Byte compiled python modules.
*.pyc *.pyc
# vim swap files # vim swap files
.*.sw? .*.sw?
.sw? .sw?
#OS X specific files. #OS X specific files.
.DS_store .DS_store
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines