This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Ignore .rej files in .gitignore
ClosedPublic

Authored by JDevlieghere on Apr 28 2022, 8:21 AM.

Details

Summary

Ignore reject files (.rej) files generated by patch. I can't imagine a reason they should ever be checked in. I'm wondering if we should ignore patch files as well but, though maybe we don't want them to be that easily deleted by something like git clean.

Diff Detail

Event Timeline

JDevlieghere created this revision.Apr 28 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 8:21 AM
JDevlieghere requested review of this revision.Apr 28 2022, 8:21 AM
vsavchenko accepted this revision.Apr 28 2022, 8:24 AM

I guess the only possible scenario that I can imagine here for including these files is tests. Tests for some code tools dealing with patches.
Otherwise, 100% reasonable.

This revision is now accepted and ready to land.Apr 28 2022, 8:24 AM
mehdi_amini accepted this revision.Apr 28 2022, 8:26 AM
This revision was landed with ongoing or failed builds.Apr 28 2022, 8:45 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 8:45 AM