This is an archive of the discontinued LLVM Phabricator instance.

Differential D124576

[mlir] Prevent argStorage relocations
ClosedPublic

Authored by vitalybuka on Apr 27 2022, 5:06 PM.

Details

Reviewers
rriddle
Group Reviewers
Restricted Project
Commits
rGf735b3a2b0ce: [mlir] Prevent argStorage relocations
Summary

This fixes msan reports like https://reviews.llvm.org/P8285

Diff Detail

Event Timeline

vitalybuka created this revision.Apr 27 2022, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 5:06 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 19 others. · View Herald Transcript
vitalybuka requested review of this revision.Apr 27 2022, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 5:06 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
vitalybuka added reviewers: Restricted Project, rriddle.Apr 27 2022, 5:08 PM
Harbormaster completed remote builds in B161704: Diff 425654.Apr 27 2022, 6:18 PM
rriddle accepted this revision.Apr 29 2022, 10:41 AM
This revision is now accepted and ready to land.Apr 29 2022, 10:41 AM
Closed by commit rGf735b3a2b0ce: [mlir] Prevent argStorage relocations (authored by vitalybuka). · Explain WhyApr 29 2022, 11:09 AM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rGf735b3a2b0ce: [mlir] Prevent argStorage relocations.

Revision Contents

PathSize
mlir/
lib/
Dialect/
ControlFlow/
IR/
1 line

Diff 426125

mlir/lib/Dialect/ControlFlow/IR/ControlFlowOps.cpp

Show First 20 Lines • Show All 699 Lines • ▼ Show 20 Lines
/// 42: ^bb3, /// 42: ^bb3,
/// ] /// ]
static LogicalResult simplifyPassThroughSwitch(SwitchOp op, static LogicalResult simplifyPassThroughSwitch(SwitchOp op,
PatternRewriter &rewriter) { PatternRewriter &rewriter) {
SmallVector<Block *> newCaseDests; SmallVector<Block *> newCaseDests;
SmallVector<ValueRange> newCaseOperands; SmallVector<ValueRange> newCaseOperands;
SmallVector<SmallVector<Value>> argStorage; SmallVector<SmallVector<Value>> argStorage;
auto caseValues = op.getCaseValues(); auto caseValues = op.getCaseValues();
argStorage.reserve(caseValues->size() + 1);
auto caseDests = op.getCaseDestinations(); auto caseDests = op.getCaseDestinations();
bool requiresChange = false; bool requiresChange = false;
for (int64_t i = 0, size = caseValues->size(); i < size; ++i) { for (int64_t i = 0, size = caseValues->size(); i < size; ++i) {
Block *caseDest = caseDests[i]; Block *caseDest = caseDests[i];
ValueRange caseOperands = op.getCaseOperands(i); ValueRange caseOperands = op.getCaseOperands(i);
argStorage.emplace_back(); argStorage.emplace_back();
if (succeeded(collapseBranch(caseDest, caseOperands, argStorage.back()))) if (succeeded(collapseBranch(caseDest, caseOperands, argStorage.back())))
requiresChange = true; requiresChange = true;
▲ Show 20 Lines • Show All 175 Lines • Show Last 20 Lines