This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho][nfc] Set test min version to 11.0
ClosedPublic

Authored by int3 on Apr 27 2022, 3:07 PM.

Details

Reviewers
thakis
Group Reviewers
Restricted Project
Commits
rG19bb38b9c93c: [lld-macho][nfc] Set test min version to 11.0
Summary

The arm64-apple-macos triple is only valid for versions >= 11.0. (If
one passes arm64-apple-macos10.15 to llvm-mc, the output's min version is still
11.0). In order to write tests easily for both target archs, let's up the
default min version in our tests.

Diff Detail

Event Timeline

int3 created this revision.Apr 27 2022, 3:07 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 27 2022, 3:07 PM
int3 requested review of this revision.Apr 27 2022, 3:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 3:07 PM
thakis accepted this revision.Apr 28 2022, 5:36 AM
thakis added a subscriber: thakis.

I don't have a problem with the change, but I also don't understand the motivation. llc (and clang) transparently setting the os to 11.0 for arm is a feature (there are no arm macs running 10.15). It makes it _easier_ to write your build files (want to target 10.14? set mmacosx-version-min=10.14, and it'll automatically do the right thing in the arm part of your build).

lld tests that want to test version handling want to use %no-arg-lld anyways so we don't have to change everything when we change this default.

So I don't get the benefit behind this change. (But I also don't see a problem with it, so feel free to land if it's useful in some way I miss!)

This revision is now accepted and ready to land.Apr 28 2022, 5:36 AM
int3 added a comment.May 4 2022, 2:50 PM

Ah I want this for my eh-frame.s test in D124561: [lld-macho] Support EH frames under arm64 in order that I can use %lld -arch arm64 rather than %no-arg-lld. (Since the macOS TBDs support both x86_64 and arm64, there's no need to specify a different -platform_version or -syslibroot.)

This revision was automatically updated to reflect the committed changes.