This is an archive of the discontinued LLVM Phabricator instance.

workflows: Add a test to ensure that the LLVM version is correct
ClosedPublic

Authored by tstellar on Apr 27 2022, 10:33 AM.

Details

Summary

This should prevent mistakes like Issue#55137.

Diff Detail

Event Timeline

tstellar created this revision.Apr 27 2022, 10:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 10:33 AM
tstellar requested review of this revision.Apr 27 2022, 10:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2022, 10:33 AM

I think this is fine. But I wonder if we should split out the version into a separate file that can be easier to parse and so we don't have to edit the version in several different places. In my last job we usually had a single VERSION file in the root that we read from CMake and all other places that needed the current version.

thieta accepted this revision.Apr 28 2022, 1:37 AM
This revision is now accepted and ready to land.Apr 28 2022, 1:37 AM

Could you also include checking llvm/utils/lit/lit/__init__.py while at it?

I think this is fine. But I wonder if we should split out the version into a separate file that can be easier to parse and so we don't have to edit the version in several different places. In my last job we usually had a single VERSION file in the root that we read from CMake and all other places that needed the current version.

I think we could put it in the cmake/ directory.

This was committed to the release/14.x branch: 2e7e14177186dc417a49dbf88493dabde0572e22

tstellar closed this revision.May 17 2022, 1:18 PM