This is an archive of the discontinued LLVM Phabricator instance.

[Darwin][UBSan][Sanitizer] abort_on_error ubsan test fix for arm64
ClosedPublic

Authored by thetruestblue on Apr 26 2022, 2:47 PM.

Details

Summary

The current darwin abort_on_error test specifically tests for a division
by zero undefined behavior. However arm does not trap by default for this
behavior. x86 signals the abort, which is why the test passes on x86.
This patch updates the test to test for a case where the ubsan runtime
specifically calls Die() to trigger an abort by default.

rdar://92108564

Diff Detail

Event Timeline

thetruestblue created this revision.Apr 26 2022, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 2:47 PM
thetruestblue requested review of this revision.Apr 26 2022, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 2:47 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln accepted this revision.Apr 26 2022, 2:52 PM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 26 2022, 2:52 PM