Page MenuHomePhabricator

[Serialization] Pack Expr ObjectKind and ValueKind into one VBR.
AcceptedPublic

Authored by sammccall on Apr 25 2022, 6:42 PM.

Details

Reviewers
kadircet
Summary

Most Exprs are serialized unabbreviated, so this saves 6 bits per expr.
This is worth 0.3% on clangd --check=clangd/AST.cpp: 42276772 -> 42187128
Not terribly much but a trivial change...

Diff Detail

Event Timeline

sammccall created this revision.Apr 25 2022, 6:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2022, 6:42 PM
Herald added a subscriber: usaxena95. · View Herald Transcript
sammccall requested review of this revision.Apr 25 2022, 6:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2022, 6:42 PM
kadircet accepted this revision.Apr 26 2022, 1:24 AM

thanks, lgtm!

This revision is now accepted and ready to land.Apr 26 2022, 1:24 AM