This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Update online help text (consistency, typo)
ClosedPublic

Authored by hawkinsw on Apr 23 2022, 4:35 PM.

Details

Summary

Update the online help text for breakpoint set to be
consistent with respect to the spelling of Objective-C
and fix a few space-related typos.

Diff Detail

Event Timeline

hawkinsw created this revision.Apr 23 2022, 4:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2022, 4:35 PM
hawkinsw requested review of this revision.Apr 23 2022, 4:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2022, 4:35 PM

I hope that I didn't SPAM you, @teemperor and @JDevlieghere ! Thanks for all that you do for the LLVM community!

JDevlieghere accepted this revision.Apr 25 2022, 7:50 AM

LGTM with the inline comment addressed.

Do you need someone to commit this for you?

lldb/source/Commands/Options.td
155–156

Seems like this line needs an extra space as well.

This revision is now accepted and ready to land.Apr 25 2022, 7:50 AM
hawkinsw updated this revision to Diff 425032.Apr 25 2022, 2:33 PM

Updating thanks to @JDevlieghere feedback!

hawkinsw marked an inline comment as done.Apr 25 2022, 2:33 PM

Added that extra space, as requested! And, yes, I will need someone to land this one for me. I am going to ask for commit access, but so far have not! Thanks for your help, @JDevlieghere !

This revision was automatically updated to reflect the committed changes.