This is an archive of the discontinued LLVM Phabricator instance.

Differential D124268

[ASan][test] Fix mismatched-new-delete in asan test unaligned_loads_and_stores.cpp
ClosedPublic

Authored by Enna1 on Apr 22 2022, 8:21 AM.

Details

Reviewers
vitalybuka
dvyukov
MaskRay
Commits
rGb99cf5f25a64: [ASan][test] Fix mismatched-new-delete in asan test unaligned_loads_and_stores.
Summary

Fix mismatched-new-delete in asan test unaligned_loads_and_stores.cpp

Diff Detail

Event Timeline

Enna1 created this revision.Apr 22 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2022, 8:21 AM
Enna1 requested review of this revision.Apr 22 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2022, 8:21 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Enna1 added reviewers: vitalybuka, dvyukov.Apr 22 2022, 8:22 AM
Enna1 retitled this revision from [ASan][NFC] Fix mismatched-new-delete in asan test to [ASan][NFC] Fix mismatched-new-delete in asan test unaligned_loads_and_stores.cpp.
Harbormaster completed remote builds in B160864: Diff 424484.Apr 22 2022, 8:38 AM
vitalybuka accepted this revision.Apr 22 2022, 11:11 AM
This revision is now accepted and ready to land.Apr 22 2022, 11:11 AM
MaskRay accepted this revision.Apr 22 2022, 3:56 PM
MaskRay retitled this revision from [ASan][NFC] Fix mismatched-new-delete in asan test unaligned_loads_and_stores.cpp to [ASan][test] Fix mismatched-new-delete in asan test unaligned_loads_and_stores.cpp.
MaskRay added a subscriber: MaskRay.

For pure test updates, it's more common to use [test] instead of [NFC].

Herald added a subscriber: StephenFan. · View Herald TranscriptApr 22 2022, 3:56 PM
Enna1 added a comment.Apr 22 2022, 5:52 PM
In D124268#3469235, @MaskRay wrote:

For pure test updates, it's more common to use [test] instead of [NFC].

Get it. Thanks ! :)

Closed by commit rGb99cf5f25a64: [ASan][test] Fix mismatched-new-delete in asan test unaligned_loads_and_stores. (authored by Enna1). · Explain WhyApr 22 2022, 8:58 PM
This revision was automatically updated to reflect the committed changes.
Enna1 added a commit: rGb99cf5f25a64: [ASan][test] Fix mismatched-new-delete in asan test unaligned_loads_and_stores..

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
2 lines

Diff 424689

compiler-rt/test/asan/TestCases/unaligned_loads_and_stores.cpp

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
// CHECK-L: main{{.*}}unaligned_loads_and_stores.cpp:[[@LINE-1]] // CHECK-L: main{{.*}}unaligned_loads_and_stores.cpp:[[@LINE-1]]
case 'M': __sanitizer_unaligned_store32(x + 13, 0); break; case 'M': __sanitizer_unaligned_store32(x + 13, 0); break;
// CHECK-M: main{{.*}}unaligned_loads_and_stores.cpp:[[@LINE-1]] // CHECK-M: main{{.*}}unaligned_loads_and_stores.cpp:[[@LINE-1]]
case 'N': __sanitizer_unaligned_store64(x + 10, 0); break; case 'N': __sanitizer_unaligned_store64(x + 10, 0); break;
// CHECK-N: main{{.*}}unaligned_loads_and_stores.cpp:[[@LINE-1]] // CHECK-N: main{{.*}}unaligned_loads_and_stores.cpp:[[@LINE-1]]
case 'O': __sanitizer_unaligned_store64(x + 14, 0); break; case 'O': __sanitizer_unaligned_store64(x + 14, 0); break;
// CHECK-O: main{{.*}}unaligned_loads_and_stores.cpp:[[@LINE-1]] // CHECK-O: main{{.*}}unaligned_loads_and_stores.cpp:[[@LINE-1]]
} }
delete x; delete[] x;
return res; return res;
} }