This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Disable memory tagging on arm64_32
ClosedPublic

Authored by ddcc on Apr 20 2022, 5:34 PM.

Details

Summary

arm64_32 is an ILP32 platform

Diff Detail

Event Timeline

ddcc created this revision.Apr 20 2022, 5:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2022, 5:34 PM
ddcc requested review of this revision.Apr 20 2022, 5:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2022, 5:34 PM

LGTM, but would it be more idiomatic to check for the _ILP32 macro?

ddcc updated this revision to Diff 424309.Apr 21 2022, 3:24 PM

Use ILP32 macro

eugenis accepted this revision.Apr 21 2022, 4:47 PM

Mild preference for !defined(__ILP32__).
LGTM

This revision is now accepted and ready to land.Apr 21 2022, 4:47 PM
This revision was automatically updated to reflect the committed changes.