This is an archive of the discontinued LLVM Phabricator instance.

Differential D123942

llvm-reduce: Don't delete triple/datalayout
ClosedPublic

Authored by arsenm on Apr 18 2022, 7:18 AM.

Details

Reviewers
aeubanks
swamulism
lebedev.ri
Summary

Removing these is extremely unhelpful and just adds extra hassle. This
is really finding out whether your test script uses -mtriple or
not. You can't meaningfully delete these fields, and the resulting
module defaults to the host.

Diff Detail

Unit TestsFailed

TimeTest
60,040 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg_mask_mf.c
60,060 msx64 debian > Clang.Driver::hip-sanitize-options.hip
60,140 msx64 debian > Clang.OpenMP::target_parallel_for_simd_codegen.cpp
60,140 msx64 debian > Clang.OpenMP::target_teams_distribute_simd_codegen.cpp

Event Timeline

arsenm created this revision.Apr 18 2022, 7:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 7:18 AM
arsenm requested review of this revision.Apr 18 2022, 7:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 7:18 AM
Herald added a subscriber: wdng. · View Herald Transcript
Harbormaster completed remote builds in B160057: Diff 423389.Apr 18 2022, 8:09 AM
aeubanks added a comment.Apr 18 2022, 12:39 PM

we probably have different experiences, but personally I do find reducing the triple/datalayout helpful, a lot of the things I reduce aren't affected by the two. I don't think it's a bad thing that this depends on whether or not the test script passes -mtriple or not, llvm-reduce is doing its job and reducing as much as possible

however, I can see why it might be annoying, and re-adding the two lines is more work than deleting them

perhaps a flag to toggle this behavior?

arsenm added a comment.Apr 18 2022, 3:17 PM
In D123942#3457398, @aeubanks wrote:

we probably have different experiences, but personally I do find reducing the triple/datalayout helpful, a lot of the things I reduce aren't affected by the two. I don't think it's a bad thing that this depends on whether or not the test script passes -mtriple or not, llvm-reduce is doing its job and reducing as much as possible

however, I can see why it might be annoying, and re-adding the two lines is more work than deleting them

perhaps a flag to toggle this behavior?

I'm trying to fix needing extra flags that I will need in 100% of cases. As far as things that are manually reducible, deleting the triple/datalayout is as easy as it gets, and about as much work as adding an option flag

aeubanks accepted this revision.Apr 20 2022, 3:04 PM
This revision is now accepted and ready to land.Apr 20 2022, 3:04 PM
swamulism accepted this revision.Apr 20 2022, 9:15 PM
arsenm closed this revision.Apr 24 2022, 8:14 AM

49aeeafda3b5a5f82020ab8ab8b4e951c552868d

Revision Contents

PathSize
llvm/
test/
tools/
llvm-reduce/
4 lines
tools/
llvm-reduce/
deltas/
4 lines

Diff 423389

llvm/test/tools/llvm-reduce/remove-module-data.ll

Show All 9 Lines
; CHECK-FILE: source_filename ; CHECK-FILE: source_filename
; CHECK-FILE: datalayout ; CHECK-FILE: datalayout
; CHECK-FILE: triple ; CHECK-FILE: triple
; CHECK-FILE: module asm ; CHECK-FILE: module asm
; CHECK-FILE: declare void @g ; CHECK-FILE: declare void @g
; CHECK-FINAL-NOT: ModuleID ; CHECK-FINAL-NOT: ModuleID
; CHECK-FINAL-NOT: source_filename ; CHECK-FINAL-NOT: source_filename
; CHECK-FINAL-NOT: datalayout ; CHECK-FINAL: datalayout
; CHECK-FINAL-NOT: triple ; CHECK-FINAL: triple
; CHECK-FINAL-NOT: module asm ; CHECK-FINAL-NOT: module asm
; CHECK-FINAL: declare void @g ; CHECK-FINAL: declare void @g
source_filename = "/tmp/a.cc" source_filename = "/tmp/a.cc"
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu" target triple = "x86_64-unknown-linux-gnu"
module asm "foo" module asm "foo"
declare void @g() declare void @g()

llvm/tools/llvm-reduce/deltas/ReduceModuleData.cpp

Show All 13 Lines
using namespace llvm; using namespace llvm;
static void clearModuleData(Oracle &O, Module &Program) { static void clearModuleData(Oracle &O, Module &Program) {
if (!Program.getModuleIdentifier().empty() && !O.shouldKeep()) if (!Program.getModuleIdentifier().empty() && !O.shouldKeep())
Program.setModuleIdentifier(""); Program.setModuleIdentifier("");
if (!Program.getSourceFileName().empty() && !O.shouldKeep()) if (!Program.getSourceFileName().empty() && !O.shouldKeep())
Program.setSourceFileName(""); Program.setSourceFileName("");
if (!Program.getDataLayoutStr().empty() && !O.shouldKeep())
Program.setDataLayout("");
if (!Program.getTargetTriple().empty() && !O.shouldKeep())
Program.setTargetTriple("");
// TODO: clear line by line rather than all at once // TODO: clear line by line rather than all at once
if (!Program.getModuleInlineAsm().empty() && !O.shouldKeep()) if (!Program.getModuleInlineAsm().empty() && !O.shouldKeep())
Program.setModuleInlineAsm(""); Program.setModuleInlineAsm("");
} }
void llvm::reduceModuleDataDeltaPass(TestRunner &Test) { void llvm::reduceModuleDataDeltaPass(TestRunner &Test) {
outs() << "*** Reducing Module Data...\n"; outs() << "*** Reducing Module Data...\n";
runDeltaPass(Test, clearModuleData); runDeltaPass(Test, clearModuleData);
} }