This is an archive of the discontinued LLVM Phabricator instance.

[clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry
ClosedPublic

Authored by jansvoboda11 on Apr 15 2022, 7:08 AM.

Details

Summary

This patch changes the member of FrameworkCacheEntry from const DirectoryEntry * to Optional<DirectoryEntryRef> in order to remove uses of the deprecated DirectoryEntry::getName().

Diff Detail

Event Timeline

jansvoboda11 created this revision.Apr 15 2022, 7:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2022, 7:08 AM
jansvoboda11 requested review of this revision.Apr 15 2022, 7:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2022, 7:08 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
bnbarham accepted this revision.Apr 15 2022, 9:16 AM
bnbarham added inline comments.
clang/lib/Lex/HeaderSearch.cpp
584
607

Is the plan to do these ones in later commits? Ie. this just does what's needed for FrameworkCacheEntry?

1192

Don't need the *

This revision is now accepted and ready to land.Apr 15 2022, 9:16 AM
jansvoboda11 marked 3 inline comments as done.Apr 20 2022, 10:00 AM
jansvoboda11 added inline comments.
clang/lib/Lex/HeaderSearch.cpp
607

I don't see a Dir->getName() call in this function, so I think we're fine just leaving this as const DirectoryEntry *.

This revision was landed with ongoing or failed builds.Apr 20 2022, 10:01 AM
This revision was automatically updated to reflect the committed changes.
jansvoboda11 marked an inline comment as done.