Test conforming & non-conforming lcobound intrinsic function semantics

[rouson]

Summary

Add a test with standard-conforming non-conforming lcobound() intrinsic function invocations. Also test that several non-conforming lcobound() invocations generate the correct error messages.

[ktras]

Since lcobound is not yet implemented, please remove the TBD error messages and add the one error message I mention in the code, so that the test can pass until it is implemented. Thanks.

flang/test/Semantics/lcobound.f90

12

Please add !ERROR: No explicit type declared for 'lcobound' before line 12.

[rouson]

Remove unimplemented "!ERROR: ..." directives.

[ktras]

The test looks great and tests a lot of different ways to violate the standard, but I have one suggestion. I would recommend adding a call to lcobound where a non-constant integer is passed to the kind argument, as the standard requires that it shall be a scalar integer constant expression.

[ktras]

Additionally, in the section of this test that sets out to have only calls that are standard-conforming, please make sure that the result of the calls are being assigned to a variable that is a scalar if the dim argument is present, and are being assigned to a variable that is an array if the dim argument in not present.

[rouson]

• Fixed left-hand-side of assignments where array is required because dim argument is not present.
• Test requirement that the kind parameters be an integer constant.
• Test violation of rank requirement for dim argument.

[ktras]

LGTM!

[rouson]

pushed to main

flang/test/Semantics/lcobound.f90

+! RUN: %python %S/test_errors.py %s %flang_fc1
+! Check for semantic errors in lcobound() function calls
+
+program lcobound_tests
+  use iso_c_binding, only : c_int32_t
+  implicit none
+
+  integer n, i, array(1), non_coarray(1), co_array[*]
+  logical non_integer
+
+  !___ standard-conforming statement with no optional arguments present ___
+  n = lcobound(co_array)
+  n = lcobound(coarray=co_array)
+
+  !___ standard-conforming statements with optional dim argument present ___
+  n = lcobound(co_array, 1)
+  n = lcobound(co_array, dim=1)
+  n = lcobound(coarray=co_array, dim=1)
+  n = lcobound( dim=1, coarray=co_array)
+
+  !___ standard-conforming statements with optional kind argument present ___
+  n = lcobound(co_array, 1, c_int32_t)
+
+  n = lcobound(co_array, 1, kind=c_int32_t)
+
+  n = lcobound(co_array, dim=1, kind=c_int32_t)
+  n = lcobound(co_array, kind=c_int32_t, dim=1)
+
+  n = lcobound(co_array, kind=c_int32_t)
+
+  n = lcobound(coarray=co_array, kind=c_int32_t)
+  n = lcobound(kind=c_int32_t, coarray=co_array)
+
+  n = lcobound(coarray=co_array, dim=1, kind=c_int32_t)
+  n = lcobound(dim=1, coarray=co_array, kind=c_int32_t)
+  n = lcobound(kind=c_int32_t, coarray=co_array, dim=1)
+  n = lcobound(dim=1, kind=c_int32_t, coarray=co_array)
+  n = lcobound(kind=c_int32_t, dim=1, coarray=co_array)
+
+  !___ non-conforming statements ___
+
+  !ERROR: TBD
+  n = lcobound(dim=i)
+
+  !ERROR: TBD
+  n = lcobound(co_array, non_integer)
+
+  !ERROR: TBD
+  n = lcobound(co_array, dim=non_integer)
+
+  !ERROR: TBD
+  n = lcobound(co_array, kind=non_integer)
+
+  !ERROR: TBD
+  n = lcobound(dim=i, kind=c_int32_t)
+
+  !ERROR: TBD
+  n = lcobound(coarray=co_array, i)
+
+  ! incorrectly typed argument
+  !ERROR: TBD
+  n = lcobound(3.4)
+
+  !ERROR: TBD
+  n = lcobound(co_array, i, c_int32_t, 0)
+
+  !ERROR: TBD
+  n = lcobound(coarray=non_coarray)
+
+  !ERROR: TBD
+  n = lcobound(co_array, i, kind=non_integer)
+
+  !ERROR: TBD
+  n = lcobound(co_array, array )
+
+  !ERROR: TBD
+  n = lcobound(c=co_array)
+
+  !ERROR: TBD
+  n = lcobound(co_array, dims=i)
+
+  !ERROR: TBD
+  n = lcobound(co_array, i, kinds=c_int32_t)
+
+end program lcobound_tests