This is an archive of the discontinued LLVM Phabricator instance.

llvm-reduce: Inform MRI of used phys reg masks
ClosedPublic

Authored by arsenm on Apr 13 2022, 3:42 PM.

Details

Summary

I'm not sure how to directly observe this invisible cache for a test.

Diff Detail

Event Timeline

arsenm created this revision.Apr 13 2022, 3:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2022, 3:42 PM
arsenm requested review of this revision.Apr 13 2022, 3:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2022, 3:42 PM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm edited the summary of this revision. (Show Details)Apr 13 2022, 3:43 PM
MatzeB accepted this revision.Apr 13 2022, 3:49 PM

I'm not sure how to directly observe this invisible cache for a test.

Only thing I can think of is to have the MachineVerifier check.

Comparing this with MIRParserImpl::setupRegisterInfo there also needs to be some handling for landing pads (getCustomEHPadPreservedMask(MF))...

Either way this change only makes things better. LGTM

This revision is now accepted and ready to land.Apr 13 2022, 3:49 PM

I'm not sure how to directly observe this invisible cache for a test.

Only thing I can think of is to have the MachineVerifier check.

Which on the other hand doesn't really work either, since this information seems to only exist after register rewriting; and I don't think the verifier has a notion of running before/after a pass like the rewriter...