This is an archive of the discontinued LLVM Phabricator instance.

[HWASan] symbolize: use buildid index for locals.
ClosedPublic

Authored by fmayer on Apr 12 2022, 4:26 PM.

Diff Detail

Event Timeline

fmayer created this revision.Apr 12 2022, 4:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 4:26 PM
Herald added a subscriber: arphaman. · View Herald Transcript
fmayer requested review of this revision.Apr 12 2022, 4:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 4:26 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov added inline comments.
compiler-rt/lib/hwasan/scripts/hwasan_symbolize
262–263

Consider splitting this into multiple lines?

fmayer marked an inline comment as done.Apr 12 2022, 4:39 PM
eugenis accepted this revision.Apr 13 2022, 5:10 PM

LGTM

compiler-rt/lib/hwasan/scripts/hwasan_symbolize
261

Please update the comment.

This revision is now accepted and ready to land.Apr 13 2022, 5:10 PM
fmayer marked an inline comment as done.Apr 13 2022, 7:08 PM
This revision was landed with ongoing or failed builds.Apr 13 2022, 7:09 PM
This revision was automatically updated to reflect the committed changes.