This is an archive of the discontinued LLVM Phabricator instance.

Differential D123539

[libc] Fix nested namespace issues with multiply_add.h.
ClosedPublic

Authored by lntue on Apr 11 2022, 1:00 PM.

Details

Reviewers
michaelrj
sivachandra
Commits
rG5c6db1dc9b83: [libc] Fix nested namespace issues with multiply_add.h.
Summary

The FMA header was included inside namespaces in multiply_add.h.

Diff Detail

Event Timeline

lntue created this revision.Apr 11 2022, 1:00 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 11 2022, 1:00 PM
Herald added subscribers: ecnelises, tschuett. · View Herald Transcript
lntue requested review of this revision.Apr 11 2022, 1:00 PM
Harbormaster completed remote builds in B159081: Diff 422015.Apr 11 2022, 1:05 PM
sivachandra accepted this revision.Apr 11 2022, 1:21 PM

Please fix the length of the subject line.

This revision is now accepted and ready to land.Apr 11 2022, 1:21 PM
lntue retitled this revision from [libc] Fix nested namespace issues with multiply_add.h due to including FMA header inside namespaces. to [libc] Fix nested namespace issues with multiply_add.h..Apr 11 2022, 2:29 PM
lntue edited the summary of this revision. (Show Details)
Closed by commit rG5c6db1dc9b83: [libc] Fix nested namespace issues with multiply_add.h. (authored by lntue). · Explain WhyApr 11 2022, 2:30 PM
This revision was automatically updated to reflect the committed changes.
lntue added a commit: rG5c6db1dc9b83: [libc] Fix nested namespace issues with multiply_add.h..

Revision Contents

PathSize
libc/
src/
__support/
FPUtil/
10 lines

Diff 422015

libc/src/__support/FPUtil/multiply_add.h

Show All 16 Lines
// Implement a simple wrapper for multiply-add operation: // Implement a simple wrapper for multiply-add operation:
// multiply_add(x, y, z) = x*y + z // multiply_add(x, y, z) = x*y + z
// which uses FMA instructions to speed up if available. // which uses FMA instructions to speed up if available.
template <typename T> static inline T multiply_add(T x, T y, T z) { template <typename T> static inline T multiply_add(T x, T y, T z) {
return x * y + z; return x * y + z;
} }
} // namespace fputil
} // namespace __llvm_libc
#if defined(LIBC_TARGET_HAS_FMA) #if defined(LIBC_TARGET_HAS_FMA)
// FMA instructions are available. // FMA instructions are available.
#include "FMA.h" #include "FMA.h"
namespace __llvm_libc {
namespace fputil {
template <> inline float multiply_add<float>(float x, float y, float z) { template <> inline float multiply_add<float>(float x, float y, float z) {
return fma(x, y, z); return fma(x, y, z);
} }
template <> inline double multiply_add<double>(double x, double y, double z) { template <> inline double multiply_add<double>(double x, double y, double z) {
return fma(x, y, z); return fma(x, y, z);
} }
#endif // LIBC_TARGET_HAS_FMA
} // namespace fputil } // namespace fputil
} // namespace __llvm_libc } // namespace __llvm_libc
#endif // LIBC_TARGET_HAS_FMA
#endif // LLVM_LIBC_SRC_SUPPORT_FPUTIL_MULTIPLY_ADD_H #endif // LLVM_LIBC_SRC_SUPPORT_FPUTIL_MULTIPLY_ADD_H