This is an archive of the discontinued LLVM Phabricator instance.

Differential D123439

[VE][compiler-rt] Correct location of VE support in clear_cache function, NFC
ClosedPublic

Authored by brad on Apr 8 2022, 8:57 PM.

Details

Reviewers
simoll
MaskRay
Commits
rG8cf83e96591b: [VE][compiler-rt] Correct location of VE support in clear_cache function, NFC
Summary

Looks like when the VE support was added it was added a few lines below where it should have been.

Diff Detail

Event Timeline

brad created this revision.Apr 8 2022, 8:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 8:57 PM
Herald added a subscriber: dberris. · View Herald Transcript
brad requested review of this revision.Apr 8 2022, 8:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 8:57 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B158817: Diff 421678.Apr 8 2022, 9:15 PM
brad added a reviewer: MaskRay.Apr 14 2022, 12:33 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptApr 14 2022, 12:33 PM
MaskRay accepted this revision.Apr 14 2022, 12:42 PM
This revision is now accepted and ready to land.Apr 14 2022, 12:42 PM
This revision was landed with ongoing or failed builds.Apr 14 2022, 12:50 PM
Closed by commit rG8cf83e96591b: [VE][compiler-rt] Correct location of VE support in clear_cache function, NFC (authored by brad). · Explain Why
This revision was automatically updated to reflect the committed changes.
brad added a commit: rG8cf83e96591b: [VE][compiler-rt] Correct location of VE support in clear_cache function, NFC.

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
4 lines

Diff 422940

compiler-rt/lib/builtins/clear_cache.c

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines#elif defined(__riscv) && defined(__linux__)
assert(start_reg == 0 && "Cache flush syscall failed."); assert(start_reg == 0 && "Cache flush syscall failed.");
#elif defined(__riscv) && defined(__OpenBSD__) #elif defined(__riscv) && defined(__OpenBSD__)
struct riscv_sync_icache_args arg; struct riscv_sync_icache_args arg;
arg.addr = (uintptr_t)start; arg.addr = (uintptr_t)start;
arg.len = (uintptr_t)end - (uintptr_t)start; arg.len = (uintptr_t)end - (uintptr_t)start;
sysarch(RISCV_SYNC_ICACHE, &arg); sysarch(RISCV_SYNC_ICACHE, &arg);
#elif defined(__ve__)
__asm__ volatile("fencec 2");
#else #else
#if __APPLE__ #if __APPLE__
// On Darwin, sys_icache_invalidate() provides this functionality // On Darwin, sys_icache_invalidate() provides this functionality
sys_icache_invalidate(start, end - start); sys_icache_invalidate(start, end - start);
#elif defined(__ve__)
__asm__ volatile("fencec 2");
#else #else
compilerrt_abort(); compilerrt_abort();
#endif #endif
#endif #endif
} }