[clang-offload-bundler] fix "no output file" issue with -outputs

[scchan]

Summary

Fix backward compatibility issue due to D120662.

Change-Id: I7cd0f704aabbaac7dcf59fd4b73b4f0e0cdfa69f

[yaxunl]

Does this mean without this fix clang-offload-bundler emits an error if -outputs option not given? How could the lit tests passed?

[saiislam]

In D123387#3439069, @yaxunl wrote:

Does this mean without this fix clang-offload-bundler emits an error if -outputs option not given? How could the lit tests passed?

I think lit tests were passing because all occurrences of -outputs were replaced with -output. It crashed internally in other components where this syntax wasn't changed.

clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp

if (TargetNames.size()) {
       reportError(createStringError(errc::invalid_argument,
                                     "-targets option is invalid for -list"));
     }
 
     doWork([]() { return ListBundleIDsInFile(InputFileNames.front()); });
     return 0;
   }
 
-  if (OutputFileNames.getNumOccurrences() == 0) {
+  if (OutputFileNames.size() == 0) {
     reportError(
         createStringError(errc::invalid_argument, "no output file specified!"));
   }
   if (TargetNames.getNumOccurrences() == 0) {
     reportError(createStringError(
         errc::invalid_argument,
         "for the --targets option: must be specified at least once!"));
   }