Page MenuHomePhabricator

[clang-offload-bundler] fix "no output file" issue with -outputs
ClosedPublic

Authored by scchan on Apr 8 2022, 6:41 AM.

Details

Summary

Fix backward compatibility issue due to D120662.

Change-Id: I7cd0f704aabbaac7dcf59fd4b73b4f0e0cdfa69f

Diff Detail

Event Timeline

scchan created this revision.Apr 8 2022, 6:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 6:41 AM
scchan requested review of this revision.Apr 8 2022, 6:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 6:41 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
yaxunl accepted this revision.Apr 8 2022, 7:28 AM

Does this mean without this fix clang-offload-bundler emits an error if -outputs option not given? How could the lit tests passed?

This revision is now accepted and ready to land.Apr 8 2022, 7:28 AM
saiislam accepted this revision.Apr 8 2022, 9:45 AM

Does this mean without this fix clang-offload-bundler emits an error if -outputs option not given? How could the lit tests passed?

I think lit tests were passing because all occurrences of -outputs were replaced with -output. It crashed internally in other components where this syntax wasn't changed.

This revision was automatically updated to reflect the committed changes.