This is an archive of the discontinued LLVM Phabricator instance.

Differential D123099

[Darwin][ASan][Sanitizer] Enable dlclose-test for all darwin targets.
ClosedPublic

Authored by rsundahl on Apr 4 2022, 4:34 PM.

Details

Reviewers
yln
delcypher
aralisza
thetruestblue
rsundahl
Commits
rG47e7a2247115: [Darwin][ASan][Sanitizer] Enable dlclose-test for all darwin targets.
Summary

Test was being skipped on non-x86 darwin architectures.

rdar://79795770

Diff Detail

Event Timeline

rsundahl created this revision.Apr 4 2022, 4:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 4:34 PM
Herald added a subscriber: pengfei. · View Herald Transcript
rsundahl requested review of this revision.Apr 4 2022, 4:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 4:34 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln accepted this revision.Apr 4 2022, 4:45 PM

LGTM, with nits.

compiler-rt/test/asan/TestCases/Posix/dlclose-test.cpp
13

Joining the grammar nitpick ;)

14

This test works on x86 and Darwin, but hasn't been confirmed working anywhere else.

This revision is now accepted and ready to land.Apr 4 2022, 4:45 PM
Harbormaster completed remote builds in B157860: Diff 420345.Apr 4 2022, 5:33 PM
rsundahl updated this revision to Diff 420452.Apr 5 2022, 4:45 AM
  1. Updated D123099: [Darwin][ASan][Sanitizer] Enable dlclose-test for all darwin targets.
  2. Fixed nits
rsundahl marked 2 inline comments as done.Apr 5 2022, 4:49 AM
rsundahl added inline comments.
compiler-rt/test/asan/TestCases/Posix/dlclose-test.cpp
14

Re-worded slightly to fit <80 characters.

rsundahl accepted this revision.Apr 5 2022, 5:00 AM
rsundahl marked an inline comment as done.

Self-approved with comment.

Harbormaster completed remote builds in B157939: Diff 420452.Apr 5 2022, 5:19 AM
This revision was landed with ongoing or failed builds.Apr 5 2022, 12:21 PM
Closed by commit rG47e7a2247115: [Darwin][ASan][Sanitizer] Enable dlclose-test for all darwin targets. (authored by rsundahl). · Explain Why
This revision was automatically updated to reflect the committed changes.
rsundahl added a commit: rG47e7a2247115: [Darwin][ASan][Sanitizer] Enable dlclose-test for all darwin targets..

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
Posix/
8 lines

Diff 420603

compiler-rt/test/asan/TestCases/Posix/dlclose-test.cpp

// Regression test for // Regression test for
// http://code.google.com/p/address-sanitizer/issues/detail?id=19 // http://code.google.com/p/address-sanitizer/issues/detail?id=19
// Bug description: // Bug description:
// 1. application dlopens foo.so // 1. application dlopens foo.so
// 2. asan registers all globals from foo.so // 2. asan registers all globals from foo.so
// 3. application dlcloses foo.so // 3. application dlcloses foo.so
// 4. application mmaps some memory to the location where foo.so was before // 4. application mmaps some memory to the location where foo.so was before
// 5. application starts using this mmaped memory, but asan still thinks there // 5. application starts using this mmaped memory, but asan still thinks there
// are globals. // are globals.
// 6. BOOM // 6. BOOM
// This sublte test assumes that after a foo.so is dlclose-d // This subtle test assumes that after a foo.so is dlclose-d
// we can mmap the region of memory that has been occupied by the library. // we can mmap the region of memory that was occupied by the library.
ylnUnsubmitted
Done
ReplyInline Actions
// This subtle test assumes that after a foo.so is dlclose-d
- // we can mmap the region of memory that was been occupied by the library.
+ // we can mmap the region of memory that was occupied by the library.
// Leaving the restriction to x86 but opening up to all darwin architectures.

Joining the grammar nitpick ;)

yln: Joining the grammar nitpick ;)
// It works on x86 Linux, but not necessary anywhere else. // This test works on x86 and Darwin, but not confirmed working anywhere else.
ylnUnsubmitted
Done
ReplyInline Actions

This test works on x86 and Darwin, but hasn't been confirmed working anywhere else.

yln: This test works on x86 and Darwin, but hasn't been confirmed working anywhere else.
rsundahlAuthorUnsubmitted
Done
ReplyInline Actions

Re-worded slightly to fit <80 characters.

rsundahl: Re-worded slightly to fit <80 characters.
// REQUIRES: x86-target-arch // REQUIRES: x86-target-arch || darwin
// RUN: %clangxx_asan -O0 -DSHARED_LIB %s -fPIC -shared -o %t-so.so // RUN: %clangxx_asan -O0 -DSHARED_LIB %s -fPIC -shared -o %t-so.so
// RUN: %clangxx_asan -O0 %s %libdl -o %t && %run %t 2>&1 | FileCheck %s // RUN: %clangxx_asan -O0 %s %libdl -o %t && %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -O1 -DSHARED_LIB %s -fPIC -shared -o %t-so.so // RUN: %clangxx_asan -O1 -DSHARED_LIB %s -fPIC -shared -o %t-so.so
// RUN: %clangxx_asan -O1 %s %libdl -o %t && %run %t 2>&1 | FileCheck %s // RUN: %clangxx_asan -O1 %s %libdl -o %t && %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -O2 -DSHARED_LIB %s -fPIC -shared -o %t-so.so // RUN: %clangxx_asan -O2 -DSHARED_LIB %s -fPIC -shared -o %t-so.so
// RUN: %clangxx_asan -O2 %s %libdl -o %t && %run %t 2>&1 | FileCheck %s // RUN: %clangxx_asan -O2 %s %libdl -o %t && %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -O3 -DSHARED_LIB %s -fPIC -shared -o %t-so.so // RUN: %clangxx_asan -O3 -DSHARED_LIB %s -fPIC -shared -o %t-so.so
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines