This is an archive of the discontinued LLVM Phabricator instance.

Differential D122893

[Support] [BLAKE3] Remove .hidden directives from windows-gnu assembly sources
ClosedPublic

Authored by mstorsjo on Apr 1 2022, 4:36 AM.

Details

Reviewers
akyrtzi
Commits
rGd0abdc22b877: [Support] [BLAKE3] Remove .hidden directives from windows-gnu assembly sources
Summary

COFF symbols don't have anything corresponding to a .hidden flag;
both GNU binutils as and LLVM's built-in assembler errors out on
these directives.

This reverts one part of
7f05aa2d4c36d6d53f97ac3e0db30ec600abbc62.

Diff Detail

Unit TestsFailed

TimeTest
60,090 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp
60,070 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,040 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,060 msx64 debian > libFuzzer.libFuzzer::large.test
60,020 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test
View Full Test Results (7 Failed)

Event Timeline

mstorsjo created this revision.Apr 1 2022, 4:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 4:36 AM
Herald added subscribers: dexonsmith, hiraditya. · View Herald Transcript
mstorsjo requested review of this revision.Apr 1 2022, 4:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 4:36 AM
Harbormaster completed remote builds in B157386: Diff 419714.Apr 1 2022, 5:19 AM
akyrtzi accepted this revision.EditedApr 1 2022, 9:58 AM

Thank you for the fix! 🙇🏻‍♂️

This revision is now accepted and ready to land.Apr 1 2022, 9:58 AM
This revision was landed with ongoing or failed builds.Apr 2 2022, 2:04 PM
Closed by commit rGd0abdc22b877: [Support] [BLAKE3] Remove .hidden directives from windows-gnu assembly sources (authored by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGd0abdc22b877: [Support] [BLAKE3] Remove .hidden directives from windows-gnu assembly sources.

Revision Contents

Diff 419714

llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S

.intel_syntax noprefix .intel_syntax noprefix
.hidden _blake3_hash_many_avx2
.hidden blake3_hash_many_avx2
.global _blake3_hash_many_avx2 .global _blake3_hash_many_avx2
.global blake3_hash_many_avx2 .global blake3_hash_many_avx2
.section .text .section .text
.p2align 6 .p2align 6
_blake3_hash_many_avx2: _blake3_hash_many_avx2:
blake3_hash_many_avx2: blake3_hash_many_avx2:
push r15 push r15
push r14 push r14
▲ Show 20 Lines • Show All 1,808 Lines • Show Last 20 Lines

llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S

.intel_syntax noprefix .intel_syntax noprefix
.hidden _blake3_hash_many_avx512
.hidden blake3_hash_many_avx512
.hidden blake3_compress_in_place_avx512
.hidden _blake3_compress_in_place_avx512
.hidden blake3_compress_xof_avx512
.hidden _blake3_compress_xof_avx512
.global _blake3_hash_many_avx512 .global _blake3_hash_many_avx512
.global blake3_hash_many_avx512 .global blake3_hash_many_avx512
.global blake3_compress_in_place_avx512 .global blake3_compress_in_place_avx512
.global _blake3_compress_in_place_avx512 .global _blake3_compress_in_place_avx512
.global blake3_compress_xof_avx512 .global blake3_compress_xof_avx512
.global _blake3_compress_xof_avx512 .global _blake3_compress_xof_avx512
.section .text .section .text
▲ Show 20 Lines • Show All 2,605 Lines • Show Last 20 Lines

llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S

.intel_syntax noprefix .intel_syntax noprefix
.hidden blake3_hash_many_sse2
.hidden _blake3_hash_many_sse2
.hidden blake3_compress_in_place_sse2
.hidden _blake3_compress_in_place_sse2
.hidden blake3_compress_xof_sse2
.hidden _blake3_compress_xof_sse2
.global blake3_hash_many_sse2 .global blake3_hash_many_sse2
.global _blake3_hash_many_sse2 .global _blake3_hash_many_sse2
.global blake3_compress_in_place_sse2 .global blake3_compress_in_place_sse2
.global _blake3_compress_in_place_sse2 .global _blake3_compress_in_place_sse2
.global blake3_compress_xof_sse2 .global blake3_compress_xof_sse2
.global _blake3_compress_xof_sse2 .global _blake3_compress_xof_sse2
.section .text .section .text
.p2align 6 .p2align 6
▲ Show 20 Lines • Show All 2,323 Lines • Show Last 20 Lines

llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S

.intel_syntax noprefix .intel_syntax noprefix
.hidden blake3_hash_many_sse41
.hidden _blake3_hash_many_sse41
.hidden blake3_compress_in_place_sse41
.hidden _blake3_compress_in_place_sse41
.hidden blake3_compress_xof_sse41
.hidden _blake3_compress_xof_sse41
.global blake3_hash_many_sse41 .global blake3_hash_many_sse41
.global _blake3_hash_many_sse41 .global _blake3_hash_many_sse41
.global blake3_compress_in_place_sse41 .global blake3_compress_in_place_sse41
.global _blake3_compress_in_place_sse41 .global _blake3_compress_in_place_sse41
.global blake3_compress_xof_sse41 .global blake3_compress_xof_sse41
.global _blake3_compress_xof_sse41 .global _blake3_compress_xof_sse41
.section .text .section .text
.p2align 6 .p2align 6
▲ Show 20 Lines • Show All 2,060 Lines • Show Last 20 Lines