This is an archive of the discontinued LLVM Phabricator instance.

[Support] [BLAKE3] Remove .hidden directives from windows-gnu assembly sources
ClosedPublic

Authored by mstorsjo on Apr 1 2022, 4:36 AM.

Details

Summary

COFF symbols don't have anything corresponding to a .hidden flag;
both GNU binutils as and LLVM's built-in assembler errors out on
these directives.

This reverts one part of
7f05aa2d4c36d6d53f97ac3e0db30ec600abbc62.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 1 2022, 4:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 4:36 AM
mstorsjo requested review of this revision.Apr 1 2022, 4:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 4:36 AM
akyrtzi accepted this revision.EditedApr 1 2022, 9:58 AM

Thank you for the fix! 🙇🏻‍♂️

This revision is now accepted and ready to land.Apr 1 2022, 9:58 AM
This revision was landed with ongoing or failed builds.Apr 2 2022, 2:04 PM
This revision was automatically updated to reflect the committed changes.