This is an archive of the discontinued LLVM Phabricator instance.

Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active union member
ClosedPublic

Authored by shafik on Mar 30 2022, 11:25 AM.

Details

Summary

NSIndexPathSyntheticFrontEnd::Impl::Clear() currently calls Clear() on both unions members regardless of which one is active. I modified it to only call Clear() on the active member.

Diff Detail

Event Timeline

shafik created this revision.Mar 30 2022, 11:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 11:25 AM
Herald added a subscriber: arphaman. · View Herald Transcript
shafik requested review of this revision.Mar 30 2022, 11:25 AM

I believe that NSIndexPathSyntheticFrontEnd::Update() also needs a fix in order to properly set the active member but I will do that as a separate fix since.

This revision is now accepted and ready to land.Mar 30 2022, 3:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 6:02 PM