This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc++][test] Move time tests.
ClosedPublic

Authored by Mordante on Mar 30 2022, 9:58 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG7738db2c06b1: [NFC][libc++][test] Move time tests.
Summary

In the C++20 Standard time is no longer section under utilities, but
became its own chapter. This moves the time tests accordingly so their
location matches the current Standard.

Diff Detail

Event Timeline

Mordante created this revision.Mar 30 2022, 9:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 9:58 AM
Herald added a subscriber: arphaman. · View Herald Transcript
Mordante requested review of this revision.Mar 30 2022, 9:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 9:58 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Apr 4 2022, 11:21 AM
This revision is now accepted and ready to land.Apr 4 2022, 11:21 AM

Before pushing this, can you please make sure no other review added something in the old directory? I don't think that's the case, but just to be sure. Thanks!

Before pushing this, can you please make sure no other review added something in the old directory? I don't think that's the case, but just to be sure. Thanks!

I only found D56692, but that's quite old and not in active development. It only adds new test so when it's revived it's probably easier to copy the existing changes to a main manually.

Before pushing this, can you please make sure no other review added something in the old directory? I don't think that's the case, but just to be sure. Thanks!

I only found D56692, but that's quite old and not in active development. It only adds new test so when it's revived it's probably easier to copy the existing changes to a main manually.

Sorry, I guess what I meant is just "please check that there are no additional tests to move after you've rebased this onto main".

I have no concerns with landing this, but we should do it soon to reduce the potential of conflicts.

Before pushing this, can you please make sure no other review added something in the old directory? I don't think that's the case, but just to be sure. Thanks!

I only found D56692, but that's quite old and not in active development. It only adds new test so when it's revived it's probably easier to copy the existing changes to a main manually.

Sorry, I guess what I meant is just "please check that there are no additional tests to move after you've rebased this onto main".

I have no concerns with landing this, but we should do it soon to reduce the potential of conflicts.

Ah clear. I'll make sure there are no extra tests after rebasing. But I'm sure there will be none.
I'll land it now.

This revision was automatically updated to reflect the committed changes.