This is an archive of the discontinued LLVM Phabricator instance.

[demangler][NFC] Use def file for node names
ClosedPublic

Authored by urnathan on Mar 30 2022, 8:46 AM.

Details

Reviewers
dblaikie
ldionne
Group Reviewers
Restricted Project
Commits
rG369337e3c222: [demangler][NFC] Use def file for node names
Summary

In order to add a unit test, we need to expose the node names beyond ItaniumDemangle.h. This breaks them out into a def file, as suggested by @dblaikie in D122665

Diff Detail

Event Timeline

urnathan created this revision.Mar 30 2022, 8:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 8:46 AM
urnathan requested review of this revision.Mar 30 2022, 8:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2022, 8:46 AM
urnathan added a reviewer: Restricted Project.Mar 31 2022, 9:45 AM
dblaikie accepted this revision.Mar 31 2022, 1:12 PM

Awesome, thanks!

This revision is now accepted and ready to land.Mar 31 2022, 1:12 PM
This revision was landed with ongoing or failed builds.Apr 1 2022, 5:03 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2022, 5:03 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript