This change is done to see whether all platforms have a CI with the
Japanese locale installed.
This wires in the locale in the tests and uses it in one test. This is
a preparation for the tests of the chrono formatters.
Paths
| Differential D122738
[libc++][test] Use the Japanese locale. ClosedPublic Authored by Mordante on Mar 30 2022, 8:35 AM.
Details
Summary This change is done to see whether all platforms have a CI with the This wires in the locale in the tests and uses it in one test. This is
Diff Detail
Unit TestsFailed Event Timeline
Comment Actions The Linux CI changes are committed, but it will take some time before they are propagated to the build nodes.
Mordante marked an inline comment as done. Comment Actions Rebased. Comment Actions This is ready for review, assuming the CI passes ;-)
Mordante retitled this revision from [libc++] Use the Japanese locale. to [libc++][test] Use the Japanese locale..Apr 7 2022, 10:35 AM Comment Actions LGTM, but have you verified that we were running that test in the CI? Since it REQUIRES: locale.ja_JP.UTF-8, we would simply skip it if the CI node didn't support that locale. Please make sure that's not what's happening, as we would simply lose coverage of that test. This revision is now accepted and ready to land.Apr 8 2022, 10:53 AM Comment Actions
Thanks for the review! I indeed have verified that, per https://reviews.llvm.org/D122738#inline-1180541 For info I tested with this value set and an assert(false); in the tests to verify all platforms support Japanese. Only on AIX it's unsupported. However this platform has a lot (all?) locale tests disabled. The build can be found here https://buildkite.com/llvm-project/libcxx-ci/builds/10064 Closed by commit rGd49c0ba5abde: [libc++][test] Use the Japanese locale. (authored by Mordante). · Explain WhyApr 8 2022, 11:00 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 419479 libcxx/test/std/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp
libcxx/test/support/platform_support.h
libcxx/utils/ci/buildkite-pipeline.yml
libcxx/utils/libcxx/test/features.py
|
clang-format suggested style edits found: