This is an archive of the discontinued LLVM Phabricator instance.

Differential D122689

[libc] Add mfma option to functions that use fma
ClosedPublic

Authored by michaelrj on Mar 29 2022, 3:07 PM.

Details

Reviewers
sivachandra
lntue
Commits
rG2f8829aba3ca: [libc] Add mfma option to functions that use fma
Summary

On Windows the functions that use fma don't properly include the fma
intrinsics unless -mfma is added to the compile options. This patch adds
the compile option to all of the functions that need it.

Diff Detail

Event Timeline

michaelrj created this revision.Mar 29 2022, 3:07 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 29 2022, 3:07 PM
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny. · View Herald Transcript
michaelrj requested review of this revision.Mar 29 2022, 3:07 PM
lntue accepted this revision.Mar 29 2022, 3:15 PM
This revision is now accepted and ready to land.Mar 29 2022, 3:15 PM
This revision was landed with ongoing or failed builds.Mar 29 2022, 4:23 PM
Closed by commit rG2f8829aba3ca: [libc] Add mfma option to functions that use fma (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG2f8829aba3ca: [libc] Add mfma option to functions that use fma.
Harbormaster completed remote builds in B156848: Diff 418997.Mar 30 2022, 11:08 AM
michaelrj mentioned this in D123335: [libc] Add support for x86-64 targets that do not have FMA instructions..Apr 7 2022, 3:51 PM

Revision Contents

PathSize
libc/
src/
math/
2 lines
generic/
6 lines

Diff 419008

libc/src/math/CMakeLists.txt

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Linesadd_entrypoint_object(
SRCS SRCS
fmaf.cpp fmaf.cpp
HDRS HDRS
fmaf.h fmaf.h
DEPENDS DEPENDS
libc.src.__support.FPUtil.fputil libc.src.__support.FPUtil.fputil
COMPILE_OPTIONS COMPILE_OPTIONS
-O2 -O2
-mfma
) )
add_entrypoint_object( add_entrypoint_object(
fma fma
SRCS SRCS
fma.cpp fma.cpp
HDRS HDRS
fma.h fma.h
DEPENDS DEPENDS
libc.src.__support.FPUtil.fputil libc.src.__support.FPUtil.fputil
COMPILE_OPTIONS COMPILE_OPTIONS
-O2 -O2
-mfma
) )
add_math_entrypoint_object(ceil) add_math_entrypoint_object(ceil)
add_math_entrypoint_object(ceilf) add_math_entrypoint_object(ceilf)
add_math_entrypoint_object(ceill) add_math_entrypoint_object(ceill)
add_math_entrypoint_object(copysign) add_math_entrypoint_object(copysign)
add_math_entrypoint_object(copysignf) add_math_entrypoint_object(copysignf)
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines

libc/src/math/generic/CMakeLists.txt

Show First 20 Lines • Show All 475 Lines • ▼ Show 20 Linesadd_entrypoint_object(
HDRS HDRS
../expf.h ../expf.h
DEPENDS DEPENDS
.common_constants .common_constants
libc.src.__support.FPUtil.fputil libc.src.__support.FPUtil.fputil
libc.include.math libc.include.math
COMPILE_OPTIONS COMPILE_OPTIONS
-O3 -O3
-mfma
) )
add_entrypoint_object( add_entrypoint_object(
exp2f exp2f
SRCS SRCS
exp2f.cpp exp2f.cpp
HDRS HDRS
../exp2f.h ../exp2f.h
DEPENDS DEPENDS
libc.src.__support.FPUtil.fputil libc.src.__support.FPUtil.fputil
libc.include.math libc.include.math
COMPILE_OPTIONS COMPILE_OPTIONS
-O3 -O3
-mfma
) )
add_entrypoint_object( add_entrypoint_object(
expm1f expm1f
SRCS SRCS
expm1f.cpp expm1f.cpp
HDRS HDRS
../expm1f.h ../expm1f.h
DEPENDS DEPENDS
.common_constants .common_constants
libc.src.__support.FPUtil.fputil libc.src.__support.FPUtil.fputil
libc.include.math libc.include.math
COMPILE_OPTIONS COMPILE_OPTIONS
-O3 -O3
-mfma
) )
add_entrypoint_object( add_entrypoint_object(
copysign copysign
SRCS SRCS
copysign.cpp copysign.cpp
HDRS HDRS
../copysign.h ../copysign.h
▲ Show 20 Lines • Show All 149 Lines • ▼ Show 20 Lines SRCS
log10f.cpp log10f.cpp
HDRS HDRS
../log10f.h ../log10f.h
DEPENDS DEPENDS
.common_constants .common_constants
libc.src.__support.FPUtil.fputil libc.src.__support.FPUtil.fputil
COMPILE_OPTIONS COMPILE_OPTIONS
-O3 -O3
-mfma
) )
add_entrypoint_object( add_entrypoint_object(
log1pf log1pf
SRCS SRCS
log1pf.cpp log1pf.cpp
HDRS HDRS
../log1pf.h ../log1pf.h
DEPENDS DEPENDS
.common_constants .common_constants
libc.src.__support.FPUtil.fputil libc.src.__support.FPUtil.fputil
COMPILE_OPTIONS COMPILE_OPTIONS
-O3 -O3
-mfma
) )
add_entrypoint_object( add_entrypoint_object(
log2f log2f
SRCS SRCS
log2f.cpp log2f.cpp
HDRS HDRS
../log2f.h ../log2f.h
Show All 10 Lines SRCS
logf.cpp logf.cpp
HDRS HDRS
../logf.h ../logf.h
DEPENDS DEPENDS
.common_constants .common_constants
libc.src.__support.FPUtil.fputil libc.src.__support.FPUtil.fputil
COMPILE_OPTIONS COMPILE_OPTIONS
-O3 -O3
-mfma
) )
add_entrypoint_object( add_entrypoint_object(
logb logb
SRCS SRCS
logb.cpp logb.cpp
HDRS HDRS
../logb.h ../logb.h
▲ Show 20 Lines • Show All 357 Lines • Show Last 20 Lines