This is an archive of the discontinued LLVM Phabricator instance.

[clang][DR] Test and mark DR1305 as complete
ClosedPublic

Authored by zero9178 on Mar 29 2022, 11:20 AM.

Details

Reviewers
erichkeane
cor3ntin
Group Reviewers
Restricted Project
Commits
rGc1e614c8eb50: [clang][DR] Test and mark DR1305 as complete
Summary

DR: http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1305

This DR has always been implemented in all clang versions as far back as I could go. This patch basically just adds a test with the needed comments to mark it as complete.

Diff Detail

Event Timeline

zero9178 created this revision.Mar 29 2022, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2022, 11:20 AM
zero9178 requested review of this revision.Mar 29 2022, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2022, 11:20 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Looks good except I think it makes more sense to put the new test just before the first test

clang/test/CXX/drs/dr13xx.cpp
15–25

I think it would make more sense to put the new test here

erichkeane accepted this revision.Mar 29 2022, 11:42 AM
erichkeane added a subscriber: erichkeane.

LGTM!

This revision is now accepted and ready to land.Mar 29 2022, 11:42 AM
zero9178 updated this revision to Diff 418941.Mar 29 2022, 11:43 AM

Address reviewers comments: Group test nicely with the other dr namespaces.

cor3ntin accepted this revision.Mar 29 2022, 11:45 AM

Looks great!

This revision was landed with ongoing or failed builds.Mar 29 2022, 11:45 AM
This revision was automatically updated to reflect the committed changes.