[Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition
ClosedPublic
Actions

Authored by MaskRay on Mar 27 2022, 10:30 PM.

Details

Reviewers

aykevl
benshi001

Commits

rG52fa1d1a0294: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition
rG16524d2f1bdc: [Driver][AVR] Fix warn_drv_avr_stdlib_not_linked condition

Summary

Many options (-fsyntax-only, -E, -S, etc) skip the link action phase which the
existing condition does not account for.

Since the code no longer specifies OPT_c, I think a single RUN line about -c
not leading to a warning is sufficient. Adding one for all of -E,
-fsyntax-only, -S would be excessive.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

MaskRay created this revision.Mar 27 2022, 10:30 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2022, 10:30 PM

Herald added subscribers: StephenFan, Jim, dylanmckay. · View Herald Transcript

MaskRay requested review of this revision.Mar 27 2022, 10:30 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2022, 10:30 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

MaskRay mentioned this in D122524: [Driver][AVR] Emit proper warnings for different options.Mar 27 2022, 10:31 PM

fix file header

benshi001 accepted this revision.Mar 28 2022, 7:43 AM

benshi001 added a child revision: D122524: [Driver][AVR] Emit proper warnings for different options.

benshi001 added inline comments.

clang/lib/Driver/ToolChains/AVR.cpp
451	I think we should warn empty CPU name in the compile stage. For example, if user specified `-c` but not `-mmcu`, then we can not run to here to warn cpu is empty. So I will accept and rebase on your code.