This is an archive of the discontinued LLVM Phabricator instance.

Differential D122423

[Clang][doc] Fix __builtin_assume wording.
ClosedPublic

Authored by Mordante on Mar 24 2022, 12:09 PM.

Details

Reviewers
serge-sans-paille
aaron.ballman
Commits
rGc3b672a34cde: [Clang][doc] Fix __builtin_assume wording.
Summary

D117296 removed wording for __builtin_assume, D120205 restored the
wording, but the last sentence was only partly restored. This restores
the rest of the last sentence.

Diff Detail

Unit TestsFailed

TimeTest
30 msx64 debian > LLVM.Analysis/BasicAA::intrinsics.ll
40 msx64 debian > LLVM.Analysis/TypeBasedAliasAnalysis::intrinsics.ll
30 msx64 debian > LLVM.Assembler::aarch64-intrinsics-attributes.ll
60 msx64 debian > LLVM.Bindings/llvm-c::debug_info.ll
30 msx64 debian > LLVM.Bitcode::compatibility-3.6.ll
View Full Test Results (30 Failed)

Event Timeline

Mordante created this revision.Mar 24 2022, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 12:09 PM
Mordante requested review of this revision.Mar 24 2022, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 12:09 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Mordante mentioned this in D122397: [libc++] Use __builtin_expect and __builtin_assume in _LIBCPP_ASSERT.Mar 24 2022, 12:23 PM
Harbormaster completed remote builds in B156119: Diff 418010.Mar 24 2022, 12:42 PM
aaron.ballman accepted this revision.Mar 24 2022, 12:59 PM

LGTM, a second time. :-D Sorry for missing that the first time.

This revision is now accepted and ready to land.Mar 24 2022, 12:59 PM
Mordante added a comment.Mar 26 2022, 5:01 AM
In D122423#3406381, @aaron.ballman wrote:

LGTM, a second time. :-D Sorry for missing that the first time.

No problem, thanks for the review.

This revision was landed with ongoing or failed builds.Mar 26 2022, 5:02 AM
Closed by commit rGc3b672a34cde: [Clang][doc] Fix __builtin_assume wording. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGc3b672a34cde: [Clang][doc] Fix __builtin_assume wording..

Revision Contents

PathSize
clang/
docs/
3 lines

Diff 418010

clang/docs/LanguageExtensions.rst

Show First 20 Lines • Show All 2,288 Lines • ▼ Show 20 Lines int foo(int x) {
return do_something_else(); return do_something_else();
} }
**Description**: **Description**:
The boolean argument to this function is defined to be true. The optimizer may The boolean argument to this function is defined to be true. The optimizer may
analyze the form of the expression provided as the argument and deduce from analyze the form of the expression provided as the argument and deduce from
that information used to optimize the program. If the condition is violated that information used to optimize the program. If the condition is violated
during execution, the behavior is undefined. The argument itself is during execution, the behavior is undefined. The argument itself is never
evaluated, so any side effects of the expression will be discarded.
Query for this feature with ``__has_builtin(__builtin_assume)``. Query for this feature with ``__has_builtin(__builtin_assume)``.
``__builtin_call_with_static_chain`` ``__builtin_call_with_static_chain``
------------------------------------ ------------------------------------
``__builtin_call_with_static_chain`` is used to perform a static call while ``__builtin_call_with_static_chain`` is used to perform a static call while
setting updating the static chain register. setting updating the static chain register.
▲ Show 20 Lines • Show All 2,288 Lines • Show Last 20 Lines