This is an archive of the discontinued LLVM Phabricator instance.

[clang] Reformat
ClosedPublic

Authored by urnathan on Mar 23 2022, 7:33 AM.

Details

Summary

Reformat some misindentation that is coincidentally close to a piece being worked on.

(Do even such obvious patches need approval?)

Diff Detail

Event Timeline

urnathan created this revision.Mar 23 2022, 7:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2022, 7:33 AM
Herald added a subscriber: arphaman. · View Herald Transcript
urnathan requested review of this revision.Mar 23 2022, 7:33 AM
dblaikie accepted this revision.Mar 23 2022, 11:09 AM

Nah, that's generally fine to do without review - though the LLVM style guide/programmer's reference/something does say not to reformat whole files for the sake of general tidiness (the reason to avoid this is to avoid complicating blame/version history, etc) - if you're going to majorly refactor a file & having the new bits be clang-formatted and the old bits be otherwise will be jarring, it may be suitable to reformat a whole file. But this sort of case of clearly misleading indentation seems quite well justified/not contentious.

This revision is now accepted and ready to land.Mar 23 2022, 11:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 5:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript