Reformat some misindentation that is coincidentally close to a piece being worked on.
(Do even such obvious patches need approval?)
Differential D122314
[clang] Reformat urnathan on Mar 23 2022, 7:33 AM. Authored by
Details
Reformat some misindentation that is coincidentally close to a piece being worked on. (Do even such obvious patches need approval?)
Diff Detail
Event TimelineComment Actions Nah, that's generally fine to do without review - though the LLVM style guide/programmer's reference/something does say not to reformat whole files for the sake of general tidiness (the reason to avoid this is to avoid complicating blame/version history, etc) - if you're going to majorly refactor a file & having the new bits be clang-formatted and the old bits be otherwise will be jarring, it may be suitable to reformat a whole file. But this sort of case of clearly misleading indentation seems quite well justified/not contentious. |