This is an archive of the discontinued LLVM Phabricator instance.

Differential D122222

[mlir][NFC] Remove redundant let assignment.
ClosedPublic

Authored by jacquesguan on Mar 22 2022, 5:10 AM.

Details

Reviewers
bondhugula
ftynse
Commits
rGf4037650e0c7: [mlir][NFC] Remove redundant let assignment.
Summary

We already have bit hasFolder = 0 in the defination of the class Op, so no need to have another let assignment here.

Diff Detail

Event Timeline

jacquesguan created this revision.Mar 22 2022, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 5:10 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 19 others. · View Herald Transcript
jacquesguan requested review of this revision.Mar 22 2022, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 5:10 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B155597: Diff 417245.Mar 22 2022, 5:28 AM
ftynse accepted this revision.Mar 22 2022, 5:30 AM
This revision is now accepted and ready to land.Mar 22 2022, 5:30 AM
Closed by commit rGf4037650e0c7: [mlir][NFC] Remove redundant let assignment. (authored by jacquesguan). · Explain WhyMar 22 2022, 7:51 PM
This revision was automatically updated to reflect the committed changes.
jacquesguan added a commit: rGf4037650e0c7: [mlir][NFC] Remove redundant let assignment..

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
SCF/
1 line

Diff 417473

mlir/include/mlir/Dialect/SCF/SCFOps.td

Show First 20 Lines • Show All 100 Lines • ▼ Show 20 Linesdef ExecuteRegionOp : SCF_Op<"execute_region", [
let results = (outs Variadic<AnyType>); let results = (outs Variadic<AnyType>);
let regions = (region AnyRegion:$region); let regions = (region AnyRegion:$region);
let hasCanonicalizer = 1; let hasCanonicalizer = 1;
let hasCustomAssemblyFormat = 1; let hasCustomAssemblyFormat = 1;
let hasFolder = 0;
let hasVerifier = 1; let hasVerifier = 1;
} }
def ForOp : SCF_Op<"for", def ForOp : SCF_Op<"for",
[AutomaticAllocationScope, DeclareOpInterfaceMethods<LoopLikeOpInterface, [AutomaticAllocationScope, DeclareOpInterfaceMethods<LoopLikeOpInterface,
["getSingleInductionVar", "getSingleLowerBound", "getSingleStep"]>, ["getSingleInductionVar", "getSingleLowerBound", "getSingleStep"]>,
DeclareOpInterfaceMethods<RegionBranchOpInterface>, DeclareOpInterfaceMethods<RegionBranchOpInterface>,
SingleBlockImplicitTerminator<"scf::YieldOp">, SingleBlockImplicitTerminator<"scf::YieldOp">,
▲ Show 20 Lines • Show All 602 Lines • Show Last 20 Lines