This is an archive of the discontinued LLVM Phabricator instance.

Remove the clang/INPUTS directory; NFC
ClosedPublic

Authored by aaron.ballman on Mar 21 2022, 8:26 AM.

Details

Summary

This directory seems to be unused. At least, when I remove it, I can still build and all of the lit tests pass for me. I can't find any real information on why this directory exists in the first place, and the fact that it hasn't been touched in 10 years (or longer in most cases) leads me to believe it's safe to remove entirely.

Diff Detail

Event Timeline

aaron.ballman created this revision.Mar 21 2022, 8:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2022, 8:26 AM
aaron.ballman requested review of this revision.Mar 21 2022, 8:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2022, 8:26 AM

I tried to intentionally break one of these tests as well, and I have no evidence that these are used/tested at all either. @rsmith is the last one to have modified these in a way that looks like they were actually USED, so unless he says otherwise (or precommit complains!), I'm good with this.

erichkeane accepted this revision.Mar 21 2022, 9:50 AM
This revision is now accepted and ready to land.Mar 21 2022, 9:50 AM
aaron.ballman closed this revision.Mar 21 2022, 9:54 AM

Thanks for the reviews! I've commit in 95cf1903cf31c03889d50b9cecc3f293956d0d44.

clang/INPUTS/cfg-nested-var-scopes.cpp