This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly][NFC] Delete type checking logic for removed ref.null instruction
ClosedPublic

Authored by asb on Mar 21 2022, 2:55 AM.

Details

Summary

D114979 changed the textual formal of ref.null - dropping ref.null in favour of ref.null_extern and ref.null_func. Therefore, the type checker no longer needs logic to handle "ref.null".

Diff Detail

Event Timeline

asb created this revision.Mar 21 2022, 2:55 AM
asb requested review of this revision.Mar 21 2022, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2022, 2:55 AM
Herald added a subscriber: aheejin. · View Herald Transcript
asb added a comment.Mar 21 2022, 3:11 AM

This patch is somewhat smaller / more straight-forward than I'd usually consider to require pre-commit code review. But I wouldn't mind a quick check in case I'd missed anything about the ref.null => ref.null_{extern,func) transition (e.g. if it is meant to be temporary or something of that nature).

pmatos accepted this revision.Mar 22 2022, 1:07 AM

lgtm, thanks.

This revision is now accepted and ready to land.Mar 22 2022, 1:07 AM
This revision was landed with ongoing or failed builds.Mar 22 2022, 9:24 AM
This revision was automatically updated to reflect the committed changes.