This is an archive of the discontinued LLVM Phabricator instance.

[clang-format][docs] Fix incorrect 'clang-format 11' option markers
ClosedPublic

Authored by kuzkry on Mar 19 2022, 4:01 AM.

Details

Summary

Introduced by 23a5090c6, some style option markers indicated
'clang-format 11', though their respective options were available in
earlier releases.

Diff Detail

Event Timeline

kuzkry created this revision.Mar 19 2022, 4:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2022, 4:01 AM
kuzkry requested review of this revision.Mar 19 2022, 4:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2022, 4:01 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Here's a list of earliest commits where each option changed in this PR was introduced:

AllowShortBlocksOnASingleLine - introduced by 17605d396118f3066a0bd4dfd128b7a8893f8b94
DeriveLineEnding - introduced by 358eaa3dcea1dee6350c2cbf80aab3c25db4d4d9
SpaceBeforeSquareBrackets - introduced by a4a7c1259e8a8f2d11fa29686a6c2834948c1358
SpaceInEmptyBlock - introduced by db4ad3603ac9bc2f118aa5f176dc04979f836c25
SpacesInConditionalStatement - introduced by 26748a321e20a7aa952ce8daa4f030c384ae7032
UseCRLF - introduced by 358eaa3dcea1dee6350c2cbf80aab3c25db4d4d9

This revision is now accepted and ready to land.Mar 19 2022, 6:59 AM
MyDeveloperDay accepted this revision.Mar 19 2022, 10:48 AM

Thanks for the review. Could you please deliver this one for me? My name and email in git format is "Krystian Kuzniarek <krystian.kuzniarek@gmail.com>"

Hi. Could you deliver this, please?

kuzkry added a comment.Apr 5 2022, 1:20 PM

Kind reminder, please deliver this revision. I don't have write access.

Kind reminder, please deliver this revision. I don't have write access.

It's not forgotten, at least by me, but I currently have no time to update my LLVM, so I could push anything.
You just could ask for push rights, especially if you want to change something more in the future.

kuzkry added a subscriber: owenpan.Apr 7 2022, 12:06 AM

@owenpan, thank you for delivery.

You just could ask for push rights, especially if you want to change something more in the future.

I will request it then. Hopefully I get accepted as apparently they check for a good "record of submitting high quality patches" (from https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).