This is an archive of the discontinued LLVM Phabricator instance.

[OpaquePointers][BitcodeReader] Enable -opaque-pointers if we see an opaque pointer type
ClosedPublic

Authored by aeubanks on Mar 18 2022, 4:53 PM.

Details

Summary

This allows us to more easily test opaque pointers e.g. in the case of
ThinLTO where we only have to pass -opaque-pointers to the frontend.

Diff Detail

Event Timeline

aeubanks created this revision.Mar 18 2022, 4:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 4:53 PM
aeubanks requested review of this revision.Mar 18 2022, 4:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 4:53 PM

still trying to figure out how bitcode is parsed to see if this works in all situations

currently we write the type table before creating values so I think this should be fine

nikic accepted this revision.Mar 20 2022, 6:36 AM
nikic added a subscriber: nikic.

LGTM

This revision is now accepted and ready to land.Mar 20 2022, 6:36 AM