This patch primarily fixes the fenv implementation on Windows, since
Windows uses the MXCSR in place of the x87 status registers for storing
information about the floating point environment. This allows FEnv to
work correctly on Windows, and successfully build.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Currently the getenv_and_setenv_test.cpp file has a failure on line 71, the rounding mode is not being properly reset to FE_TONEAREST, it's still set to FE_DOWNWARD.
libc/src/__support/FPUtil/x86_64/FEnvImpl.h | ||
---|---|---|
413 | Why do we need to do some extra clean up for the default environment? |
libc/src/__support/FPUtil/x86_64/FEnvImpl.h | ||
---|---|---|
377 | You should either name these bit masks or add comments to tell which flag is set in each line. | |
484 | You should name these bit masks to make it easier to keep track and debug which flag is set in which line. Also look like they can be re-used for control word also. |
You should either name these bit masks or add comments to tell which flag is set in each line.