Page MenuHomePhabricator

[AVR] Fix incorrect calling convention for varargs functions
ClosedPublic

Authored by benshi001 on Mar 15 2022, 8:11 PM.

Details

Summary

An i8 argument should only cost 1 byte on the stack. This is
compatible with avr-gcc.

There are also more test cases (of calling convention) are added.

Diff Detail

Event Timeline

benshi001 created this revision.Mar 15 2022, 8:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 8:11 PM
Herald added subscribers: Jim, hiraditya. · View Herald Transcript
benshi001 requested review of this revision.Mar 15 2022, 8:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 8:11 PM

The failure information is caused by the build machines, not my patch.

aykevl accepted this revision.Mar 22 2022, 5:40 PM

I assume you've verified the new test cases with avr-gcc? If so, this looks good to me.

This revision is now accepted and ready to land.Mar 22 2022, 5:40 PM

I assume you've verified the new test cases with avr-gcc? If so, this looks good to me.

Yes. Verified with avr-gcc 7.3.0.

This revision was landed with ongoing or failed builds.Mar 22 2022, 7:00 PM
This revision was automatically updated to reflect the committed changes.